Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct token creation CLI to ensure it works with default expiry #10084

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

corban-beaird
Copy link
Contributor

@corban-beaird corban-beaird commented Oct 18, 2024

Ticket

Description

In the event that expiration_days isn't provided, this corrects the missed declaration of the expiration_in_hours variable.

Test Plan

  • det token create successfully creates a token with the default expiration duration.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 7484def
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6712cacc7fecdf00086c87a8

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.40%. Comparing base (27a014b) to head (7484def).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
harness/determined/cli/token.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10084      +/-   ##
==========================================
+ Coverage   54.39%   54.40%   +0.01%     
==========================================
  Files        1267     1267              
  Lines      159323   159324       +1     
  Branches     3630     3631       +1     
==========================================
+ Hits        86658    86675      +17     
+ Misses      72531    72515      -16     
  Partials      134      134              
Flag Coverage Δ
backend 45.57% <ø> (+0.03%) ⬆️
harness 72.55% <0.00%> (-0.01%) ⬇️
web 53.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
harness/determined/cli/token.py 16.00% <0.00%> (-0.17%) ⬇️

... and 6 files with indirect coverage changes

@corban-beaird corban-beaird merged commit b70a622 into main Oct 18, 2024
91 of 103 checks passed
@corban-beaird corban-beaird deleted the corban/empty-token-create-fix branch October 18, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants