-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: return error if workspace config violates global constraints #10076
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10076 +/- ##
==========================================
- Coverage 58.81% 54.43% -4.39%
==========================================
Files 757 1267 +510
Lines 105981 159371 +53390
Branches 3631 3631
==========================================
+ Hits 62330 86748 +24418
- Misses 43517 72489 +28972
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more.
|
a13e804
to
58048fb
Compare
423ac00
to
f566a0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the change set can be simplified. Let's see if we can
- use one function to unmarshal global config policies (whether NTSC or Experiment)
- keep function names consistent
61a31cc
to
142faa0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
142faa0
to
b82cf31
Compare
Ticket
CM-575
Description
Return error if workspace invariant config violates global constraints
Test Plan
CI passes (automated testing)
Checklist
docs/release-notes/
See Release Note for details.