chore: ntsc config not supported #10056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10056 +/- ##
==========================================
- Coverage 54.43% 54.43% -0.01%
==========================================
Files 1262 1262
Lines 158894 158901 +7
Branches 3631 3632 +1
==========================================
- Hits 86498 86491 -7
- Misses 72262 72276 +14
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Deploy Preview for determined-ui canceled.
|
kkunapuli
commented
Oct 15, 2024
| @@ -211,7 +220,7 @@ func configPolicyConflict(config1, config2 interface{}) { | |||
| if field1.IsValid() && field2.IsValid() && !field1.IsZero() && !field2.IsZero() { | |||
| // For non-pointer fields, compare directly if both are non-zero | |||
| if !reflect.DeepEqual(field1.Interface(), field2.Interface()) { | |||
| ConfigPolicyWarning(fmt.Sprintf("%s: %v, %v", GlobalConfigConflictErr, field1.Interface(), field2.Interface())) | |||
| ConfigPolicyWarning(fmt.Sprintf("%s: field=%s", GlobalConfigConflictErr, v1.Type().Field(i).Name)) | |||
There was a problem hiding this comment.
This was confusing: it just printed out the memory address of both fields. We could determine if the field is a pointer or not and print each case differently ... but it seemed simpler and more clear to simply tell the admin which field conflicts.
carolinaecalderon
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
CM-559
Description
Returns an error if admins set invariant config for NTSC. Also fixes some nil pointer issues and refines error message when there's a conflict between global and workspace config policies.
Test Plan
Checklist
docs/release-notes/See Release Note for details.