-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: default priority earlier to ensure constraints are satisfied [CM-553] #10043
Conversation
…traints are satisfied
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10043 +/- ##
==========================================
- Coverage 54.62% 54.61% -0.02%
==========================================
Files 1260 1260
Lines 157621 157631 +10
Branches 3632 3631 -1
==========================================
- Hits 86102 86083 -19
- Misses 71385 71414 +29
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
} | ||
|
||
// DefaultPriorityForPool returns the default priority for any jobs (user-defined if provided, otherwise our default). | ||
func DefaultPriorityForPool(rpName string) int { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this helper!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, awesome work!
Co-authored-by: Amanda Vialva <[email protected]>
Ticket
CM-553
Description
If we set priorities earlier during launch, then the constraint checks will apply to the default, too. This prevents jobs getting through when a limit conflicts with a default, which is strange but could be used to effectively force users to submit with a priority.
Test Plan
TBD.
Checklist
docs/release-notes/
See Release Note for details.