-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Global Config Policies UI [CM-522] #10022
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10022 +/- ##
==========================================
- Coverage 54.60% 50.58% -4.02%
==========================================
Files 1259 950 -309
Lines 157329 128826 -28503
Branches 3621 3636 +15
==========================================
- Hits 85902 65169 -20733
+ Misses 71294 63523 -7771
- Partials 133 134 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
messages LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally looks good, had a few nits
Ticket
CM-522, CM-521
Description
Adds page for Global Config Policies UI
Test Plan
Only in EE:
Should display "Config Policies" as option in Navigation Sidebar.
"Config Policies" Page should display secondary tabs for "Experiments" and "Tasks"
Non-admin should not see Apply button, and should see CodeEditor in read-only mode.
Admin should be able to Apply (with valid YAML syntax that modifies what's fetched).
Should be able to remove all YAML and Apply without error.
Checklist
docs/release-notes/
See Release Note for details.