-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove formatDatetime
#10011
fix: remove formatDatetime
#10011
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10011 +/- ##
==========================================
- Coverage 54.57% 50.53% -4.05%
==========================================
Files 1259 949 -310
Lines 157233 128576 -28657
Branches 3620 3616 -4
==========================================
- Hits 85807 64971 -20836
+ Misses 71293 63472 -7821
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I'm not 100% clear on the reasoning behind the removal.
|
Ticket
CM-550
Description
Remove
formatDatetime
because it would cause inconsistent date/datetime format in the future, and no need to manually manipulate dateString.Test Plan
Checklist
docs/release-notes/
See Release Note for details.