feat: Config Policies UI, Workspaces Experiments [CM-521]

[johnkim-det]

Ticket

CM-521

Description

Add secondary tabs for "Experiments" and "Tasks" to "Config Policies" tab on Workspace Details page. Also made changes to

• call delete endpoint when saving an empty document
• Not display JSON brackets when loading with empty config policies object
• display CodeEditor in read-only mode when user does not have permissions to modify

Test Plan

Only in EE:
"Config Policies" tab on Workspace Details page should display secondary tabs for "Experiments" and "Tasks"
Non-admin should not see Apply button, and should see CodeEditor in read-only mode.
Admin should be able to Apply (with valid YAML syntax that modifies what's fetched).
Should be able to remove all YAML and Apply without error.

Checklist

• Changes have been manually QA'd
• New features have been approved by the corresponding PM
• User-facing API changes have the "User-facing API Change" label
• Release notes have been added as a separate file under docs/release-notes/
  See Release Note for details.
• Licenses have been included for new code which was copied and/or modified from any external code

[netlify]

✅ Deploy Preview for determined-ui ready!

Name	Link
🔨 Latest commit	0fa8e1b
🔍 Latest deploy log	https://app.netlify.com/sites/determined-ui/deploys/66fd750751a9eb0008122265
😎 Deploy Preview	https://deploy-preview-10009--determined-ui.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

Attention: Patch coverage is 72.00000% with 28 lines in your changes missing coverage. Please review.

Project coverage is 50.57%. Comparing base (25ca6d0) to head (0fa8e1b).
Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
webui/react/src/components/ConfigPolicies.tsx	67.46%	27 Missing ⚠️
webui/react/src/services/apiConfig.ts	90.90%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10009      +/-   ##
==========================================
- Coverage   54.59%   50.57%   -4.02%     
==========================================
  Files        1258      949     -309     
  Lines      157136   128623   -28513     
  Branches     3617     3616       -1     
==========================================
- Hits        85795    65057   -20738     
+ Misses      71208    63433    -7775     
  Partials      133      133              

Flag	Coverage Δ
harness	?
web	54.37% <72.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
webui/react/src/services/api.ts	97.83% <100.00%> (+0.01%)	⬆️
webui/react/src/services/apiConfig.ts	74.19% <90.90%> (+0.08%)	⬆️
webui/react/src/components/ConfigPolicies.tsx	68.09% <67.46%> (+3.02%)	⬆️

... and 309 files with indirect coverage changes

[kkunapuli]

The screenshots of the code change look great! I love how experiments and tasks are in separate tabs. I think it's organized and clear.

From a project perspective, LGTM! I will leave the code review to more qualified people. :)

[gt2345]

I logged in as admin but do not have MODIFY_WORKSPACE_CONFIG_POLICIES permission, I wonder which roles have this permission?
I feel like it would be clearer to have an explicit Delete button, but not a blocker.