test: playwright timeout config [TESTENG-12] (#9558)

determined-ai · Jun 24, 2024 · c87f04e · c87f04e
1 parent 86ed69f
commit c87f04e
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 12 deletions.
diff --git a/webui/react/playwright.config.ts b/webui/react/playwright.config.ts
@@ -23,8 +23,6 @@ export default defineConfig({
   /* Run tests in files in parallel */
   fullyParallel: !!process.env.CI,
 
-  /* https://playwright.dev/docs/test-timeouts#global-timeout */
-  globalTimeout: process.env.PWDEBUG ? 0 : 1_800_000,
   /* Folder for test artifacts such as screenshots, videos, traces, etc. */
   outputDir: './src/e2e/test-results',
   /* Folder for test artifacts such as screenshots, videos, traces, etc. */
@@ -78,15 +76,12 @@ export default defineConfig({
   retries: process.env.CI ? 1 : 0,
 
   testDir: './src/e2e',
-  timeout: 90_000, // TODO [INFENG-628] Users page loads slow so we extend 5 minutes and 1 minute per test until we get an isolated backend
+  timeout: 90_000, // webkit takes longer to run tests
 
   /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */
   use: {
     actionTimeout: 5_000,
-    /* Base URL to use in actions like `await page.goto('/')`. */
     baseURL: `http://localhost:${port}/`,
-
-    /* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */
     navigationTimeout: 10_000,
     trace: 'retain-on-failure',
     video: 'retain-on-failure',

diff --git a/webui/react/src/e2e/tests/experimentList.spec.ts b/webui/react/src/e2e/tests/experimentList.spec.ts
@@ -80,7 +80,6 @@ test.describe('Experiement List', () => {
 
   test.skip('Column Picker Check and Uncheck', async () => {
     // BUG [ET-287]
-    test.slow();
     const columnTitle = 'Forked From',
       columnTestid = 'forkedFrom';
     const columnPicker = projectDetailsPage.f_experiemntList.tableActionBar.columnPickerMenu;

diff --git a/webui/react/src/e2e/tests/projectsWorkspaces.spec.ts b/webui/react/src/e2e/tests/projectsWorkspaces.spec.ts
@@ -8,7 +8,6 @@ import { Workspaces } from 'e2e/models/pages/Workspaces';
 import { randId, safeName } from 'e2e/utils/naming';
 
 test.describe('Projects', () => {
-  test.slow();
   let wsCreatedWithButton = '';
   let wsCreatedWithSidebar = '';
   let projectOneName = '';

diff --git a/webui/react/src/e2e/tests/userManagement.spec.ts b/webui/react/src/e2e/tests/userManagement.spec.ts
@@ -83,8 +83,6 @@ test.describe('User Management', () => {
       });
 
       test('Deactivate and Reactivate', async ({ page, user, auth, newAdmin }) => {
-        // test does does three and a half logins, so we need to increase the timeout
-        test.slow();
         const userManagementPage = new UserManagement(page);
         const signInPage = new SignIn(page);
         await test.step('Deactivate', async () => {
@@ -131,7 +129,6 @@ test.describe('User Management', () => {
     test.describe('With 10 Users', () => {
       const usernamePrefix = 'test-user-pagination';
       test.beforeAll(async ({ backgroundApiUser }) => {
-        test.slow();
         await test.step('Create User', async () => {
           // pagination will be 10 per page, so create 11 users
           for (let i = 0; i < 11; i++) {
@@ -218,7 +215,6 @@ test.describe('User Management', () => {
       });
 
       test('Users Table Row Count matches Users Tab Value', async ({ page }) => {
-        test.slow();
         const userManagementPage = new UserManagement(page);
         const getExpectedRowCount = async (): Promise<number> => {
           const match = (await userManagementPage.userTab.pwLocator.innerText()).match(