Skip to content

Commit

Permalink
feat: add Search actions [ET-603] (#9622)
Browse files Browse the repository at this point in the history
  • Loading branch information
emily-roses authored Jul 10, 2024
1 parent 1ec5d01 commit c0fc4c4
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 11 deletions.
21 changes: 10 additions & 11 deletions webui/react/src/pages/ExperimentDetails/ExperimentDetailsHeader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ const ExperimentDetailsHeader: React.FC<Props> = ({
},
],
},
[experiment, ContinueExperimentModal, ContinueTrialModal.open, ReactivateExperimentModal, isRunningContinue, onClickContinueMultiTrialExp],
[experiment, ContinueExperimentModal, ReactivateExperimentModal, isRunningContinue, onClickContinueMultiTrialExp, ContinueTrialModal.open],
);

useEffect(() => {
Expand Down Expand Up @@ -374,7 +374,6 @@ const ExperimentDetailsHeader: React.FC<Props> = ({
},
],
},

[Action.ContinueTrial]: {
...continueExperimentOption,
key: 'continue-trial',
Expand Down Expand Up @@ -552,22 +551,22 @@ const ExperimentDetailsHeader: React.FC<Props> = ({

return availableActions.map((action) => options[action]) as ActionOptions[];
}, [
expPermissions,
isRunningArchive,
continueExperimentOption,
isRunningDelete,
ExperimentDeleteModal,
ForkModal,
ExperimentEditModal,
ExperimentMoveModal,
ExperimentRetainLogsModal,
HyperparameterSearchModal,
ExperimentDeleteModal.open,
experiment,
HyperparameterSearchModal.open,
erroredTrialCount,
ForkModal.open,
ExperimentEditModal.open,
ExperimentMoveModal.open,
ExperimentRetainLogsModal.open,
isRunningTensorBoard,
isRunningUnarchive,
experiment,
expPermissions,
fetchExperimentDetails,
confirm,
erroredTrialCount,
]);

const jobInfoLinkText = useMemo(() => {
Expand Down
9 changes: 9 additions & 0 deletions webui/react/src/pages/SearchDetails.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import handleError, { ErrorLevel, ErrorType } from 'utils/error';
import { isAborted, isNotFound } from 'utils/service';

import ExperimentCodeViewer from './ExperimentDetails/ExperimentCodeViewer';
import ExperimentDetailsHeader from './ExperimentDetails/ExperimentDetailsHeader';
import FlatRuns from './FlatRuns/FlatRuns';

const TabType = {
Expand Down Expand Up @@ -217,6 +218,14 @@ const SearchDetails: React.FC = () => {
return (
<Page
breadcrumb={pageBreadcrumb}
headerComponent={
experiment && (
<ExperimentDetailsHeader
experiment={experiment}
fetchExperimentDetails={fetchExperimentDetails}
/>
)
}
notFound={pageError && isNotFound(pageError)}
stickyHeader
title={`Search ${searchId}`}>
Expand Down

0 comments on commit c0fc4c4

Please sign in to comment.