fix: reset settings not working properly due to url encoding (#10000)

determined-ai · Oct 1, 2024 · 7f88390 · 7f88390
1 parent 25ca6d0
commit 7f88390
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/webui/react/src/hooks/useSettings.ts b/webui/react/src/hooks/useSettings.ts
@@ -44,7 +44,7 @@ const settingsToQuery = <T>(config: SettingsConfig<T>, settings: Settings) => {
 
   if (qParams.toString().length !== 0) {
     for (const param of qParams.keys()) {
-      if (settings[param] === undefined) {
+      if (!(param in settings)) {
         // passing all non-setting param into the retval
         retVal.append(param, qParams.get(param) as string);
       }
@@ -248,13 +248,15 @@ const useSettings = <T>(config: SettingsConfig<T>): UseSettingsReturn<T> => {
             });
 
             userSettings.remove(config.storagePath);
-
+            const mappedSettings = settingsToQuery(config, news);
+            const url = mappedSettings ? `?${mappedSettings}` : '';
+            navigate(url, { replace: true });
             return news;
           });
         });
       });
     },
-    [config, currentUser, rawState],
+    [config, currentUser, rawState, navigate],
   );
 
   const updateSettings = useCallback(