Skip to content

Commit

Permalink
chore: default flat runs to on (#9709)
Browse files Browse the repository at this point in the history
Co-authored-by: Tara <[email protected]>
(cherry picked from commit 7260f04)
  • Loading branch information
ashtonG authored and determined-ci committed Jul 25, 2024
1 parent f84d4eb commit 5e22807
Show file tree
Hide file tree
Showing 5 changed files with 51 additions and 2 deletions.
16 changes: 16 additions & 0 deletions docs/release-notes/run-centric-ux.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
:orphan:

**New Features**

- WebUI: In the Experimental features, Flat Runs View is now "on" by default in the :ref:`WebUI
<web-ui-if>`\. Users can still toggle this feature "off".
- This update improves the ability to compare model performance between different trials, based on
user feedback that most Determined users run single-trial experiments.
- "Experiments" is now renamed to "searches" and "trials" is now renamed to "runs" for better
clarity.
- The "experiment list" is renamed the "run list", showing all trials from experiments in the
project. It functions similarly to the previous new experiment list.
- Multi-trial experiments can be viewed in the new searches view, which allows for sorting,
filtering and navigating multi-trial experiments.
- When viewing a multi-trial experiment, a list of trials is displayed, allowing for sorting,
filtering and arbitrary comparison between trials.
3 changes: 2 additions & 1 deletion webui/react/src/components/ProjectCard.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ const projectMock: Project = {
notes: [],
numActiveExperiments: 1,
numExperiments: 16,
numRuns: 16,
state: 'UNSPECIFIED',
userId: 1354,
workspaceId: 1684,
Expand Down Expand Up @@ -53,7 +54,7 @@ describe('ProjectCard', () => {
it('should display experiments count', () => {
setup();
expect(
screen.getByText(projectMock.numExperiments?.toString() ?? 'Count undefined'),
screen.getByText(projectMock.numRuns?.toString() ?? 'Count undefined'),
).toBeInTheDocument();
});

Expand Down
22 changes: 22 additions & 0 deletions webui/react/src/e2e/fixtures/global-fixtures.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,17 @@ export const test = baseTest.extend<CustomFixtures, CustomWorkerFixtures>({
username: newAdmin.user!.username,
},
});
await apiAuth.apiContext?.post('/api/v1/users/setting', {
data: {
settings: [
{
key: 'flat_runs',
storagePath: 'global-features',
value: 'false',
},
],
},
});
await use(apiAuth);
},

Expand Down Expand Up @@ -68,6 +79,17 @@ export const test = baseTest.extend<CustomFixtures, CustomWorkerFixtures>({
async ({ playwright, browser }, use) => {
const backgroundApiAuth = new ApiAuthFixture(playwright.request, browser, apiUrl());
await backgroundApiAuth.loginApi();
await backgroundApiAuth.apiContext?.post('/api/v1/users/setting', {
data: {
settings: [
{
key: 'flat_runs',
storagePath: 'global-features',
value: 'false',
},
],
},
});
await use(backgroundApiAuth);
await backgroundApiAuth.dispose();
},
Expand Down
2 changes: 1 addition & 1 deletion webui/react/src/hooks/useFeature.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const FEATURES: Record<ValidFeature, FeatureDescription> = {
friendlyName: 'New Experiment List',
},
flat_runs: {
defaultValue: false,
defaultValue: true,
description:
'Presents all runs in a project in a single view, rather than grouped into experiments',
friendlyName: 'Flat Runs View',
Expand Down
10 changes: 10 additions & 0 deletions webui/react/src/pages/ExperimentDetails/ExperimentDetails.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,16 @@ vi.mock('react-router-dom', async (importOriginal) => ({
useParams: vi.fn(),
}));

vi.mock('hooks/useFeature', () => {
return {
default: () => ({
isOn() {
return false;
},
}),
};
});

vi.mock('services/api', () => ({
getExperimentDetails: vi.fn(),
getExpTrials: vi.fn(),
Expand Down

0 comments on commit 5e22807

Please sign in to comment.