Skip to content

Commit

Permalink
fix: show search progress in run table
Browse files Browse the repository at this point in the history
  • Loading branch information
EmilyBonar committed Sep 24, 2024
1 parent 924f663 commit 50a2e59
Showing 1 changed file with 15 additions and 18 deletions.
33 changes: 15 additions & 18 deletions webui/react/src/pages/FlatRuns/columns.ts
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,22 @@ export const getColumnDefs = ({
tooltip: () => undefined,
width: columnWidths.experimentName ?? defaultColumnWidths.experimentName ?? MIN_COLUMN_WIDTH,
},

experimentProgress: {
id: 'experimentProgress',
renderer: (record: FlatRun) => handleEmptyCell(record.experiment?.progress, (data) => ({
allowOverlay: false,
data: floatToPercent(data, 0),
displayData: floatToPercent(data, 0),
kind: GridCellKind.Text,
})),
title: 'Search Progress',
tooltip: () => undefined,
width:
columnWidths.experimentProgress ?? defaultColumnWidths.experimentProgress ?? MIN_COLUMN_WIDTH,
},
// TODO: should this change to search?
externalExperimentId: {
externalExperimentId: {
id: 'externalExperimentId',
renderer: (record: FlatRun) =>
handleEmptyCell(record.experiment?.externalExperimentId, (data) => ({
Expand Down Expand Up @@ -351,23 +365,6 @@ export const getColumnDefs = ({
tooltip: () => undefined,
width: columnWidths.parentArchived ?? defaultColumnWidths.parentArchived ?? MIN_COLUMN_WIDTH,
},
progress: {
id: 'experimentProgress',
renderer: (record: FlatRun) => {
const percentage = floatToPercent(record.experiment?.progress ?? 0, 0);

return {
allowOverlay: false,
data: percentage,
displayData: percentage,
kind: GridCellKind.Text,
};
},
title: 'Search Progress',
tooltip: () => undefined,
width:
columnWidths.experimentProgress ?? defaultColumnWidths.experimentProgress ?? MIN_COLUMN_WIDTH,
},
resourcePool: {
id: 'resourcePool',
renderer: (record: FlatRun) =>
Expand Down

0 comments on commit 50a2e59

Please sign in to comment.