Skip to content

Commit

Permalink
chore: add 'masterService.annotations' to Helm (#9697)
Browse files Browse the repository at this point in the history
  • Loading branch information
NicholasBlaskey authored Jul 29, 2024
1 parent 5f8dae3 commit 35ec077
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 0 deletions.
4 changes: 4 additions & 0 deletions docs/reference/deploy/helm-config-reference.rst
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,10 @@
- ``imagePullSecretName``: Specifies the image pull secret for pulling the Determined master image.
Required when using the enterprise edition.

- ``masterService``: Specifies the configuration applied to the service for the Determined master.

- ``annotations``: Enables adding custom annotations to the Determined master service.

- ``telemetry``: Specifies whether we collect anonymous information about the usage of Determined.

- ``enabled``: Whether collection is enabled. Defaults to ``true``.
Expand Down
3 changes: 3 additions & 0 deletions helm/charts/determined/templates/master-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ metadata:
app: determined-master-{{ .Release.Name }}
determined.ai/master-service: "true"
release: {{ .Release.Name }}
{{- if (.Values.masterService).annotations }}
annotations: {{- toYaml .Values.masterService.annotations | nindent 4 }}
{{- end }}
spec:
ports:
- port: {{ required "A valid Values.masterPort entry required!" .Values.masterPort }}
Expand Down
5 changes: 5 additions & 0 deletions helm/charts/determined/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,11 @@ createNonNamespacedObjects: true
# load-balancer.
useNodePortForMaster: false

# Allow specifying annotations that will be put on the master service.
# masterService:
# annotations:
# a: b

# Enable route support for Openshift by setting enabled to true. Configure tls termination (i.e edge) if needed.
# openshiftRoute:
# enabled:
Expand Down

0 comments on commit 35ec077

Please sign in to comment.