-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow pippin to merge PROBIA designations #91
Comments
I just learned about this issue; please point to output on disk (or restore if it was clobbered). |
Proposed solution: We add a flag to
So that you can group classifiers together. I think I prefer this for a few reasons.
|
… multiple classifers to point to the same probability column.
Issue #91: Implemented a MERGE_CLASSIFIER key to AGGREGATION to allow…
Resolved via f8cfb2d |
Morning! (or evening)
This is admittedly as much of an SNANA issue as it is a pippin one, but I think the pippin-side fix is easier.
So for SALT2mu, when using photometric samples, SNANA requires a
varname_pIa
key to work. This varname_pIa key typically corresponds to the output of a classifier. And that's great for a single sample!But when combining samples, such as SDSS and PS1, this causes it to immediately crash, since I can either specify the SDSS classifier or the PS1 classifier, but not both.
What I've been doing in the interim is waiting for the 6_BIASCOR step to crash, running a script to rename probabilities in 5_MERGE, then rerunning by hand after copying all the hash.txt values (because otherwise things will get overwritten and it'll crash again!).
While this works, it's a bit ugly, and I think this is gonna end up being a significant issue in the future as we move more towards photometric samples!
The text was updated successfully, but these errors were encountered: