Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Option to disable notifications #6

Closed
simurai opened this issue Jun 7, 2018 · 5 comments
Closed

[Feature Request] Option to disable notifications #6

simurai opened this issue Jun 7, 2018 · 5 comments

Comments

@simurai
Copy link

simurai commented Jun 7, 2018

Would it be possible to add an option to disable sending a GitHub notification when an issue gets locked? Not sure if Probot supports that feature?

It's not a big issue for people that get GitHub notifications by email since they can create a filter. But for Web Notifications having all the locked issues show up again makes it quite noisy.

screen shot 2018-06-07 at 8 24 25 am

@dessant
Copy link
Owner

dessant commented Jun 7, 2018

The notifications are created while posting comments, I think there is no good way for the comment author to prevent these notifications. The app can be configured to skip posting comments, I'd check in with @lee-dohm about it. Though they were in favor of explaining the reason of the lock and mentioning further actions that could be taken by users.

@simurai
Copy link
Author

simurai commented Jun 7, 2018

Thanks for the super 🚀 fast answer.

Ok, I see. It's the comment that actually sends the notifications. And comments without a notification are probably not allowed with the GitHub API.

Though they were in favor of explaining the reason of the lock and mentioning further actions that could be taken by users.

Yeah, I can see the benefit of adding a comment to explain why it got locked. 👍

@simurai simurai closed this as completed Jun 7, 2018
@dessant
Copy link
Owner

dessant commented Jun 7, 2018

A feature request could also be rised internally for ignoring notifications from certain users and apps, like on social networks. This is currently possible only by blocking users, but you can't block apps.

@simurai
Copy link
Author

simurai commented Jun 7, 2018

Or it could also be something that the Web notifications can improve. Like allowing to "mute" certain notifications, like you can mute tweets that contain certain words.

@dessant
Copy link
Owner

dessant commented Jun 7, 2018

Yeah, such advanced filtering would be awesome. 💃

KaelWD added a commit to vuetifyjs/vuetify that referenced this issue Apr 21, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants