Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions CI workflow is currently failing #1

Open
mdempsky opened this issue Mar 31, 2022 · 3 comments
Open

GitHub Actions CI workflow is currently failing #1

mdempsky opened this issue Mar 31, 2022 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@mdempsky
Copy link
Collaborator

E.g., the logs at gh run view --job 5776534338 --log | cat -n show that packages loader and types are currently failing (lines 589 and 48360), but they don't mention any individual tests that actually failed.

What's going on here? Why are the tests failing? Why aren't there additional details logged?

Am I running into resource limits with GitHub Actions? (What are those limits? How do I tell how close I am to hitting them?)

How can I reproduce the failures locally? Why I try running just go test -v -race ./... with either Go 1.17 or Go 1.18, it succeeds.

@mdempsky mdempsky added the help wanted Extra attention is needed label Mar 31, 2022
mdempsky added a commit that referenced this issue Mar 31, 2022
It seems like some of the tests use a lot of CPU/memory and might be
failing because of that.

Updates #1.
@mdempsky
Copy link
Collaborator Author

Changing the workflow to use go test -short seems to have worked around the test failures. Leaving this issue open until I have answers to my questions above.

@zephyrtronium
Copy link

It looks like amigo/loader.TestStdlib and amigo/types.TestStdlibSSA time out in the CI runner. That may explain why -short fixes them. I don't think the problem is a hard limit in GitHub Actions, since the tests on package types ostensibly run strictly after those on package loader, but I'm not sure why it doesn't print that the tests timed out.

@mdempsky
Copy link
Collaborator Author

mdempsky commented Apr 1, 2022

I did notice when running the tests locally, they take a lot of memory and started to swap. I wonder if they're getting OOM killed or something on GitHub's runners, and go test doesn't report that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants