fix: do not allow to answer a poll after voting period ends #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riccardo Montagnin <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #964 +/- ##
==========================================
- Coverage 82.46% 82.43% -0.03%
==========================================
Files 167 168 +1
Lines 14244 14289 +45
==========================================
+ Hits 11746 11779 +33
- Misses 2014 2023 +9
- Partials 484 487 +3
Continue to review full report at Codecov.
|
Signed-off-by: Riccardo Montagnin <[email protected]>
Signed-off-by: Riccardo Montagnin <[email protected]>
…/improve-polls-answers
Signed-off-by: Riccardo Montagnin <[email protected]>
Signed-off-by: Riccardo Montagnin <[email protected]>
dadamu
reviewed
Jul 14, 2022
x/posts/legacy/v4/store.go
Outdated
|
|
||
| // removeUserAnswers iterates over all the polls and deletes the user answers for all the polls which | ||
| // final results already been tallied. This is to delete all the answers that have been added after that. | ||
| func removeUserAnswers(store sdk.KVStore, cdc codec.BinaryCodec) error { |
There was a problem hiding this comment.
I would name it removeInvalidAnswers.
Signed-off-by: Riccardo Montagnin <[email protected]>
dadamu
reviewed
Jul 14, 2022
Co-authored-by: Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug within the
x/postsmodule that currently allows users to answer a poll even when it's already ended.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change