-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to specify a post's tags #942
Conversation
Signed-off-by: Riccardo Montagnin <[email protected]>
Signed-off-by: Riccardo Montagnin <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #942 +/- ##
==========================================
- Coverage 82.74% 82.64% -0.11%
==========================================
Files 166 167 +1
Lines 14004 14142 +138
==========================================
+ Hits 11588 11688 +100
- Misses 1943 1976 +33
- Partials 473 478 +5
Continue to review full report at Codecov.
|
Signed-off-by: Riccardo Montagnin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, just some minor things in test can be improved.
…/improve-post-tags � Conflicts: � x/posts/types/models_test.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to go
Description
This PR allows to specify a post's tag for categorization. This way developers will be able to categorize and search posts (using third party tools) based on the associated tags.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change