Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to specify a post's tags #942

Merged
merged 4 commits into from
Jun 28, 2022
Merged

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Jun 27, 2022

Description

This PR allows to specify a post's tag for categorization. This way developers will be able to categorize and search posts (using third party tools) based on the associated tags.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Signed-off-by: Riccardo Montagnin <[email protected]>
@github-actions github-actions bot added the x/CLI label Jun 27, 2022
Signed-off-by: Riccardo Montagnin <[email protected]>
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #942 (786c8ae) into master (8186cab) will decrease coverage by 0.10%.
The diff coverage is 70.89%.

❗ Current head 786c8ae differs from pull request most recent head 6d0db90. Consider uploading reports for the commit 6d0db90 to get more accurate results

@@            Coverage Diff             @@
##           master     #942      +/-   ##
==========================================
- Coverage   82.74%   82.64%   -0.11%     
==========================================
  Files         166      167       +1     
  Lines       14004    14142     +138     
==========================================
+ Hits        11588    11688     +100     
- Misses       1943     1976      +33     
- Partials      473      478       +5     
Impacted Files Coverage Δ
x/posts/module.go 8.00% <0.00%> (-0.34%) ⬇️
x/posts/legacy/v3/store.go 69.15% <69.15%> (ø)
x/posts/types/models.go 77.37% <75.00%> (+0.52%) ⬆️
x/posts/keeper/msg_server.go 89.76% <100.00%> (+0.03%) ⬆️
x/posts/types/msgs.go 96.96% <100.00%> (+0.13%) ⬆️
x/reactions/keeper/msg_server.go 96.38% <0.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8186cab...6d0db90. Read the comment docs.

Signed-off-by: Riccardo Montagnin <[email protected]>
@RiccardoM RiccardoM requested review from leobragaz and dadamu June 27, 2022 14:14
@RiccardoM RiccardoM marked this pull request as ready for review June 27, 2022 14:14
@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Jun 27, 2022
Copy link
Contributor

@dadamu dadamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, just some minor things in test can be improved.

…/improve-post-tags

� Conflicts:
�	x/posts/types/models_test.go
Copy link
Contributor

@leobragaz leobragaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go

@mergify mergify bot merged commit d3cb129 into master Jun 28, 2022
@mergify mergify bot deleted the riccardom/improve-post-tags branch June 28, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass x/CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants