fix: add missing events to x/profiles #759

RiccardoM · 2022-02-28T10:52:09Z

Description

This PR adds missing events inside the x/profiles modukes

Closes: #721

Depends-On: #750

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

Signed-off-by: Riccardo Montagnin <[email protected]>

…subspace-module-adr-impl � Conflicts: � x/profiles/types/models_chain_links.pb.go

Signed-off-by: Riccardo Montagnin <[email protected]>

… files Signed-off-by: Riccardo Montagnin <[email protected]>

Signed-off-by: Riccardo Montagnin <[email protected]>

…ps module Signed-off-by: Riccardo Montagnin <[email protected]>

…relationships-module � Conflicts: � app/app.go � app/desmos/cmd/chainlink/create_json_test.go � app/params/weights.go � client/docs/swagger-ui/swagger.yaml � proto/desmos/profiles/v1beta1/query_relationships.proto � proto/desmos/profiles/v2/models_relationships.proto � proto/desmos/profiles/v3/genesis.proto � proto/desmos/profiles/v3/msg_server.proto � proto/desmos/profiles/v3/msgs_dtag_requests.proto � proto/desmos/profiles/v3/msgs_profile.proto � proto/desmos/profiles/v3/msgs_relationships.proto � proto/desmos/profiles/v3/query.proto � proto/desmos/profiles/v3/query_relationships.proto � proto/desmos/relationships/v1/query.proto � proto/desmos/subspaces/v1/genesis.proto � proto/desmos/subspaces/v1/msgs.proto � proto/desmos/subspaces/v1/query.proto � x/profiles/client/cli/cli_test.go � x/profiles/keeper/genesis_test.go � x/profiles/keeper/grpc_query.go � x/profiles/keeper/grpc_query_test.go � x/profiles/keeper/invariants.go � x/profiles/keeper/invariants_test.go � x/profiles/keeper/keeper.go � x/profiles/keeper/migrations.go � x/profiles/keeper/msg_server_blocks.go � x/profiles/keeper/msg_server_relationships.go � x/profiles/keeper/msg_server_relationships_test.go � x/profiles/legacy/v2/models_relationships.pb.go � x/profiles/legacy/v3/store.go � x/profiles/module.go � x/profiles/simulation/decoder.go � x/profiles/simulation/decoder_test.go � x/profiles/simulation/genesis.go � x/profiles/simulation/operations.go � x/profiles/types/genesis.go � x/profiles/types/genesis.pb.go � x/profiles/types/genesis_test.go � x/profiles/types/keys.go � x/profiles/types/msg_server.pb.go � x/profiles/types/msgs_dtag_requests.pb.go � x/profiles/types/msgs_profile.pb.go � x/profiles/types/query.pb.go � x/profiles/types/query.pb.gw.go � x/relationships/client/cli/tx.go � x/relationships/keeper/blocks.go � x/relationships/keeper/blocks_test.go � x/relationships/keeper/msg_server_test.go � x/relationships/keeper/relationships.go � x/relationships/simulation/operations_relationships.go � x/relationships/types/models.go � x/relationships/types/msg_server.pb.go � x/relationships/types/msgs.go � x/relationships/types/query.pb.go � x/subspaces/client/cli/cli_test.go � x/subspaces/client/cli/query.go � x/subspaces/client/cli/tx.go � x/subspaces/handler.go � x/subspaces/keeper/alias_functions.go � x/subspaces/keeper/genesis.go � x/subspaces/keeper/genesis_test.go � x/subspaces/keeper/groups.go � x/subspaces/keeper/groups_test.go � x/subspaces/keeper/grpc_query.go � x/subspaces/keeper/grpc_query_test.go � x/subspaces/keeper/invariants.go � x/subspaces/keeper/invariants_test.go � x/subspaces/keeper/keeper.go � x/subspaces/keeper/msg_server.go � x/subspaces/keeper/msg_server_test.go � x/subspaces/keeper/permissions.go � x/subspaces/keeper/permissions_test.go � x/subspaces/keeper/subspaces.go � x/subspaces/keeper/subspaces_test.go � x/subspaces/simulation/decoder.go � x/subspaces/simulation/decoder_test.go � x/subspaces/simulation/genesis.go � x/subspaces/simulation/operations.go � x/subspaces/simulation/operations_groups.go � x/subspaces/simulation/operations_permissions.go � x/subspaces/simulation/operations_subspaces.go � x/subspaces/simulation/utils.go � x/subspaces/types/codec.go � x/subspaces/types/events.go � x/subspaces/types/genesis.go � x/subspaces/types/genesis.pb.go � x/subspaces/types/genesis_test.go � x/subspaces/types/keys.go � x/subspaces/types/msgs.go � x/subspaces/types/msgs.pb.go � x/subspaces/types/msgs_test.go � x/subspaces/types/permissions.go � x/subspaces/types/query.go � x/subspaces/types/query.pb.go � x/subspaces/types/query.pb.gw.go Signed-off-by: Riccardo Montagnin <[email protected]>

Signed-off-by: Riccardo Montagnin <[email protected]>

…nto riccardo/relationships-module

Signed-off-by: Riccardo Montagnin <[email protected]>

…space is deleted Signed-off-by: Riccardo Montagnin <[email protected]>

Signed-off-by: Riccardo Montagnin <[email protected]>

…into riccardo/relationships-module � Conflicts: � x/subspaces/simulation/genesis.go

Signed-off-by: Riccardo Montagnin <[email protected]>

codecov · 2022-02-28T10:58:32Z

Codecov Report

Merging #759 (41a193f) into master (8998def) will increase coverage by 0.10%.
The diff coverage is 89.13%.

@@            Coverage Diff             @@
##           master     #759      +/-   ##
==========================================
+ Coverage   81.22%   81.32%   +0.10%     
==========================================
  Files          77       77              
  Lines        6195     6239      +44     
==========================================
+ Hits         5032     5074      +42     
- Misses        932      934       +2     
  Partials      231      231

Impacted Files	Coverage Δ
x/profiles/keeper/msg_server_app_link.go	`0.00% <0.00%> (ø)`
x/profiles/keeper/msg_server_chain_link.go	`100.00% <100.00%> (ø)`
x/profiles/keeper/msg_server_dtag_transfers.go	`76.19% <100.00%> (+4.76%)`	⬆️
x/profiles/keeper/msgs_server_profile.go	`82.85% <100.00%> (+4.28%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8998def...41a193f. Read the comment docs.

Signed-off-by: Riccardo Montagnin <[email protected]>

…s/desmos into riccardo/fix-profiles-events

Signed-off-by: Riccardo Montagnin <[email protected]>

…fix-profiles-events � Conflicts: � .github/workflows/sims.yml � app/sim_test.go � x/profiles/types/events.go

RiccardoM · 2022-03-01T11:21:38Z

app/sim_test.go

@@ -229,6 +231,7 @@ func TestAppImportExport(t *testing.T) {

 		{app.keys[subspacestypes.StoreKey], newApp.keys[subspacestypes.StoreKey], [][]byte{}},
 		{app.keys[profilestypes.StoreKey], newApp.keys[profilestypes.StoreKey], [][]byte{}},
+		{app.keys[relationshipstypes.StoreKey], newApp.keys[relationshipstypes.StoreKey], [][]byte{}},


This is to fix @bragaz comment on the relationships PR which I didn't address due to the automerge

## Description This PR improves the gRPC queries for the x/profiles module by moving some parameters from the URL to the query Closes: #757 Depends-On: #759 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://docs.cosmos.network/v0.44/building-modules/intro.html) - [ ] included the necessary unit and integration [tests](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)

RiccardoM and others added 30 commits January 14, 2022 10:29

added the Proto definitions of the subspaces types and messages

10efacc

Signed-off-by: Riccardo Montagnin <[email protected]>

improved the Proto file definition

32f7981

Signed-off-by: Riccardo Montagnin <[email protected]>

improved the Proto file definition

9293ae2

Signed-off-by: Riccardo Montagnin <[email protected]>

started working on the implementation of the message server methods

ed8e474

Signed-off-by: Riccardo Montagnin <[email protected]>

more work on the handling of messages

b0f4f61

Signed-off-by: Riccardo Montagnin <[email protected]>

added unit tests for subspaces and permissions

fca2aa9

Signed-off-by: Riccardo Montagnin <[email protected]>

completed the keeper package tests

e08f3b3

Signed-off-by: Riccardo Montagnin <[email protected]>

completed tests for the types package

3fe18f4

Signed-off-by: Riccardo Montagnin <[email protected]>

Merge branch 'master' of github.com:desmos-labs/desmos into riccardo/…

5a3362f

…subspace-module-adr-impl � Conflicts: � x/profiles/types/models_chain_links.pb.go

added the CLI tests

735a1fd

Signed-off-by: Riccardo Montagnin <[email protected]>

added the integration tests

a4d22bd

Signed-off-by: Riccardo Montagnin <[email protected]>

added changeset entry

78a5499

Signed-off-by: Riccardo Montagnin <[email protected]>

updated x/profiles to use the correct type for subspaces ids

8233131

Signed-off-by: Riccardo Montagnin <[email protected]>

added initial subspaces id to the subspaces genesis

10e2a71

Signed-off-by: Riccardo Montagnin <[email protected]>

fixed simulation tests

c7006d3

Signed-off-by: Riccardo Montagnin <[email protected]>

added changeset entry for x/profiles

2b04da8

Signed-off-by: Riccardo Montagnin <[email protected]>

fixed formatting

d28fef6

Signed-off-by: Riccardo Montagnin <[email protected]>

added migration for both modules

5a557c3

Signed-off-by: Riccardo Montagnin <[email protected]>

fixed lint

7d91aed

Signed-off-by: Riccardo Montagnin <[email protected]>

chore: updated Proto packages to match real versions

4c62789

Signed-off-by: Riccardo Montagnin <[email protected]>

chore: renamed subspace fields to subspace_id inside x/profiles Proto…

1615ab3

… files Signed-off-by: Riccardo Montagnin <[email protected]>

small lint

5dd2122

Signed-off-by: Riccardo Montagnin <[email protected]>

chore: replaced all expErr with shouldErr

e422c23

Signed-off-by: Riccardo Montagnin <[email protected]>

moved all the relationships-related things into the new x/relationshi…

4fc9328

…ps module Signed-off-by: Riccardo Montagnin <[email protected]>

Updated Swagger definition

d53accf

fixed compilation errors

a85a164

Signed-off-by: Riccardo Montagnin <[email protected]>

improving tests

93608a6

Signed-off-by: Riccardo Montagnin <[email protected]>

Merge remote-tracking branch 'origin/riccardo/relationships-module' i…

b437666

…nto riccardo/relationships-module

fixed unit tests

3f40b9e

Signed-off-by: Riccardo Montagnin <[email protected]>

RiccardoM added 6 commits February 28, 2022 08:58

fixed handler comment

7ee6fb7

Signed-off-by: Riccardo Montagnin <[email protected]>

added the subspace hook to delete relationships and blocks when a sub…

cda19c2

…space is deleted Signed-off-by: Riccardo Montagnin <[email protected]>

fixed hooks tests

f91d6bc

Signed-off-by: Riccardo Montagnin <[email protected]>

Merge branch 'riccardo/fix-actions' of github.com:desmos-labs/desmos …

a46f4c3

…into riccardo/relationships-module � Conflicts: � x/subspaces/simulation/genesis.go

fix: added missing x/profiles events

f4c1721

Signed-off-by: Riccardo Montagnin <[email protected]>

fixed simulation tests

c62adf3

Signed-off-by: Riccardo Montagnin <[email protected]>

github-actions bot added kind/build Related to the build of the project kind/ci Improve the CI/CD x/CLI x/profiles Module that allows to create and manage decentralized social profiles x/subspaces Issue on the x/subspaces module labels Feb 28, 2022

RiccardoM added 4 commits February 28, 2022 12:01

fixed simulation tests

82e9d2b

Signed-off-by: Riccardo Montagnin <[email protected]>

Merge branch 'riccardo/relationships-module' of github.com:desmos-lab…

eab8001

…s/desmos into riccardo/fix-profiles-events

added changeset entry

f8558cc

Signed-off-by: Riccardo Montagnin <[email protected]>

Merge branch 'master' of github.com:desmos-labs/desmos into riccardo/…

41a193f

…fix-profiles-events � Conflicts: � .github/workflows/sims.yml � app/sim_test.go � x/profiles/types/events.go

github-actions bot removed x/CLI x/subspaces Issue on the x/subspaces module kind/build Related to the build of the project kind/ci Improve the CI/CD labels Mar 1, 2022

RiccardoM commented Mar 1, 2022

View reviewed changes

RiccardoM requested review from leobragaz and dadamu March 1, 2022 11:21

RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Mar 1, 2022

RiccardoM mentioned this pull request Mar 1, 2022

fix: improve x/profiles gRPC queries #760

Merged

19 tasks

leobragaz approved these changes Mar 1, 2022

View reviewed changes

dadamu approved these changes Mar 2, 2022

View reviewed changes

mergify bot merged commit ce83cc5 into master Mar 2, 2022

mergify bot deleted the riccardo/fix-profiles-events branch March 2, 2022 05:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add missing events to x/profiles #759

fix: add missing events to x/profiles #759

RiccardoM commented Feb 28, 2022

codecov bot commented Feb 28, 2022 •

edited

Loading

RiccardoM Mar 1, 2022

fix: add missing events to x/profiles #759

fix: add missing events to x/profiles #759

Conversation

RiccardoM commented Feb 28, 2022

Description

Author Checklist

Reviewers Checklist

codecov bot commented Feb 28, 2022 • edited Loading

Codecov Report

RiccardoM Mar 1, 2022

Choose a reason for hiding this comment

codecov bot commented Feb 28, 2022 •

edited

Loading