feat: ADR-009: Make MsgSaveProfile DTag optional

x/profiles/client/cli/cli_profile.go

@@ -13,31 +13,31 @@ import (
 	"github.com/desmos-labs/desmos/v2/x/profiles/types"
 )
 
-// GetCmdSaveProfile returns the command used to save a profile
 func GetCmdSaveProfile() *cobra.Command {
 	cmd := &cobra.Command{
-		Use:   "save [dtag]",
-		Args:  cobra.ExactArgs(1),
-		Short: "Save your profile associating to it the given DTag.",
+		Use:   "save",
+		Args:  cobra.NoArgs,
+		Short: "Save your profile",
 		Long: fmt.Sprintf(`
-Save a new profile or edit the existing one specifying a DTag, a nickname, biography, profile picture and cover picture.
-Every data given through the flags is optional.
-If you are editing an existing profile you should fill only the fields that you want to edit.
-The empty ones will be filled with a special [do-not-modify] flag that tells the system to not edit them.
-
-%s tx profiles save LeoDiCap \
-	--%s "Leonardo Di Caprio" \
-	--%s "Hollywood actor. Proud environmentalist" \
-	--%s "https://profilePic.jpg" \
-	--%s "https://profileCover.jpg"
-`, version.AppName, FlagNickname, FlagBio, FlagProfilePic, FlagCoverPic),
+ Save a new profile or edit the existing one specifying a DTag, a nickname, biography, profile picture and cover picture.
+ Every data given through the flags is optional.
+ If you are editing an existing profile you should fill only the fields that you want to edit.
+ The empty ones will be filled with a special [do-not-modify] flag that tells the system to not edit them.
+
+ %s tx profiles save 
+ 	--%s "LeoDiCaprio" \
+ 	--%s "Leonardo Di Caprio" \
+ 	--%s "Hollywood actor. Proud environmentalist" \
+ 	--%s "https://profilePic.jpg" \
+ 	--%s "https://profileCover.jpg"
+ `, version.AppName, FlagDTag, FlagNickname, FlagBio, FlagProfilePic, FlagCoverPic),
 		RunE: func(cmd *cobra.Command, args []string) error {
 			clientCtx, err := client.GetClientTxContext(cmd)
 			if err != nil {
 				return err
 			}
 
-			dTag := args[0]
+			dTag, _ := cmd.Flags().GetString(FlagDTag)
 			nickname, _ := cmd.Flags().GetString(FlagNickname)
 			bio, _ := cmd.Flags().GetString(FlagBio)
 			profilePic, _ := cmd.Flags().GetString(FlagProfilePic)
@@ -52,6 +52,7 @@ The empty ones will be filled with a special [do-not-modify] flag that tells the
 		},
 	}
 
+	cmd.Flags().String(FlagDTag, types.DoNotModify, "DTag to be used")
 	cmd.Flags().String(FlagNickname, types.DoNotModify, "Nickname to be used")
 	cmd.Flags().String(FlagBio, types.DoNotModify, "Biography to be used")
 	cmd.Flags().String(FlagProfilePic, types.DoNotModify, "Profile picture")

x/profiles/client/cli/cli_profile_test.go

@@ -115,7 +115,7 @@ func (s *IntegrationTestSuite) TestCmdSaveProfile() {
 		{
 			name: "correct data returns no error",
 			args: []string{
-				"dtag",
+				fmt.Sprintf("--%s=%s", cli.FlagDTag, "dtag"),
 				fmt.Sprintf("--%s=%s", flags.FlagFrom, val.Address.String()),
 				fmt.Sprintf("--%s=true", flags.FlagSkipConfirmation),
 				fmt.Sprintf("--%s=%s", flags.FlagBroadcastMode, flags.BroadcastBlock),

x/profiles/client/cli/keys.go

@@ -1,6 +1,7 @@
 package cli
 
 const (
+	FlagDTag       = "dtag"
 	FlagNickname   = "nickname"
 	FlagBio        = "bio"
 	FlagProfilePic = "profile-pic"

x/profiles/types/account_test.go

@@ -176,6 +176,21 @@ func TestProfile_Validate(t *testing.T) {
 			)),
 			shouldErr: true,
 		},
+		{
+			name: "setting DTag to DoNotModify returns error",
+			account: testutil.AssertNoProfileError(types.NewProfile(
+				types.DoNotModify,
+				"",
+				"bio",
+				types.NewPictures(
+					"https://shorturl.at/adnX3",
+					"https://shorturl.at/cgpyF",
+				),
+				time.Now(),
+				testutil.AccountFromAddr("cosmos1y54exmx84cqtasvjnskf9f63djuuj68p7hqf47"),
+			)),
+			shouldErr: true,
+		},
 		{
 			name: "invalid profile picture returns error",
 			account: testutil.AssertNoProfileError(types.NewProfile(

x/profiles/types/msgs_profile.go

@@ -2,8 +2,6 @@ package types
 
 import (
 	"fmt"
-	"strings"
-
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
 )
@@ -37,10 +35,6 @@ func (msg MsgSaveProfile) ValidateBasic() error {
 		return sdkerrors.Wrap(sdkerrors.ErrInvalidAddress, fmt.Sprintf("invalid creator: %s", msg.Creator))
 	}
 
-	if strings.TrimSpace(msg.DTag) == "" {
-		return sdkerrors.Wrap(sdkerrors.ErrInvalidRequest, "profile dtag cannot be empty or blank")
-	}
-
 	return nil
 }
 

x/profiles/types/msgs_profile_test.go

@@ -45,18 +45,6 @@ func TestMsgSaveProfile_ValidateBasic(t *testing.T) {
 			),
 			shouldErr: true,
 		},
-		{
-			name: "empty DTag returns error",
-			msg: types.NewMsgSaveProfile(
-				"",
-				"",
-				"",
-				"",
-				"",
-				"cosmos1cjf97gpzwmaf30pzvaargfgr884mpp5ak8f7ns",
-			),
-			shouldErr: true,
-		},
 		{
 			name:      "valid message returns no error",
 			msg:       msgEditProfile,

x/profiles/types/query_app_links.go

@@ -1,7 +1,7 @@
 package types
 
 import (
-	query "github.com/cosmos/cosmos-sdk/types/query"
+	"github.com/cosmos/cosmos-sdk/types/query"
 )
 
 // NewQueryApplicationLinksRequest returns a new QueryApplicationLinksRequest instance