-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make profiles query user parameter optional #539
Conversation
Codecov Report
@@ Coverage Diff @@
## master #539 +/- ##
==========================================
+ Coverage 82.81% 82.84% +0.03%
==========================================
Files 91 91
Lines 5470 5480 +10
==========================================
+ Hits 4530 4540 +10
Misses 737 737
Partials 203 203
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add some tests to make sure that the different comination (0, 1 args) work properly?
Unit tests added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all the QueryUserXXXXX
should be renamed to QueryXXXXX
now since the user is optional. This applied to both *Request
and *Response
Proto definitions
@RiccardoM I see, then, the prefix |
Co-authored-by: Riccardo Montagnin <[email protected]>
Co-authored-by: Riccardo Montagnin <[email protected]>
Co-authored-by: Riccardo Montagnin <[email protected]>
Co-authored-by: Riccardo Montagnin <[email protected]>
Co-authored-by: Riccardo Montagnin <[email protected]>
Co-authored-by: Riccardo Montagnin <[email protected]>
Description
This PR is the implementation of #534.
Closes #534
Checklist
CHANGELOG.md
file.Files changed
in the Github PR explorer.