build(deps)!: bump cosmos sdk to v0.50.3 #1246
Conversation
github-actions
bot
added
x/profiles
dadamu
force-pushed
the
paul/DCD-415/bump-cosmos-sdk-to-0.50.0
branch
4 times, most recently
from
cc1acbf
to
90d6c17
Compare
dadamu
changed the title
dadamu
force-pushed
the
paul/DCD-415/bump-cosmos-sdk-to-0.50.0
branch
4 times, most recently
from
1a6a59a
to
68287ee
Compare
|
|
||
| // MsgSaveProfile represents a message to save a profile. | ||
| message MsgSaveProfile { |
There was a problem hiding this comment.
structures of MsgServices must be inside the same file as MsgServices, or cosmos.msg.v1.signer cannot be detected properly.
dadamu
force-pushed
the
paul/DCD-415/bump-cosmos-sdk-to-0.50.0
branch
from
884d2f7
to
0b4cb2e
Compare
| @@ -1,25 +1,35 @@ | |||
| module github.com/desmos-labs/desmos/v6 | |||
|
|
|||
| go 1.19 | |||
| go 1.21 | |||
There was a problem hiding this comment.
Currently, cosmos-sdk, wasmd and ibc-go are set 1.21 as minimal version. Additionally, ibc-go applies features go 1.20 package.
dadamu
force-pushed
the
paul/DCD-415/bump-cosmos-sdk-to-0.50.0
branch
from
89ecc6e
to
6bdb126
Compare
| upgradeclient.LegacyProposalHandler, | ||
| upgradeclient.LegacyCancelProposalHandler, | ||
| ibcclientclient.UpdateClientProposalHandler, | ||
| ibcclientclient.UpgradeProposalHandler, |
There was a problem hiding this comment.
govv1beta1 proposal handler are deprecated
| @@ -30,7 +30,7 @@ func NewAccountChainLinkJSONBuilder(getter getter.MultiSignatureAccountReference | |||
| } | |||
|
|
|||
| // BuildChainLinkJSON implements ChainLinkJSONBuilder | |||
| func (b *AccountChainLinkJSONBuilder) BuildChainLinkJSON(_ codec.Codec, chain types.Chain) (utils.ChainLinkJSON, error) { | |||
| func (b *AccountChainLinkJSONBuilder) BuildChainLinkJSON(ctx client.Context, chain types.Chain) (utils.ChainLinkJSON, error) { | |||
There was a problem hiding this comment.
inject client.Context for signing data since client.Context is required for signing bytes in this version
| // | ||
| // CONTRACT: Validator array must be provided in the order expected by Tendermint. | ||
| // i.e. sorted first by power and then lexicographically by address. | ||
| func NewTestChainWithValSet(tb testing.TB, coord *ibctesting.Coordinator, chainID string, valSet *cmttypes.ValidatorSet, signers map[string]cmttypes.PrivValidator) *ibctesting.TestChain { |
There was a problem hiding this comment.
FinalizeBlock is applied in cosmos-sdk v0.50, it breaks the ibctesting tool features, so I decided to wrap the existing tool from ibc-go, instead of maintaining it by ourselves.
x/profiles/types/codec.go
Outdated
| var ( | ||
| amino = codec.NewLegacyAmino() | ||
|
|
||
| // AminoCdc references the global x/relationships module codec. Note, the codec should | ||
| // ONLY be used in certain instances of tests and for JSON encoding as Amino is | ||
| // still used for that purpose. | ||
| // | ||
| // The actual codec used for serialization should be provided to x/relationships and | ||
| // defined at the application level. | ||
| AminoCdc = codec.NewAminoCodec(amino) | ||
|
|
||
| ModuleCdc = codec.NewProtoCodec(types.NewInterfaceRegistry()) | ||
| ) | ||
|
|
||
| func init() { | ||
| RegisterLegacyAminoCodec(amino) | ||
| cryptocodec.RegisterCrypto(amino) | ||
| sdk.RegisterLegacyAminoCodec(amino) | ||
|
|
||
| // Register all Amino interfaces and concrete types on the authz Amino codec so that this can later be | ||
| // used to properly serialize MsgGrant and MsgExec instances | ||
| RegisterLegacyAminoCodec(authzcodec.Amino) | ||
|
|
||
| // Register all Amino interfaces and concrete types on the gov Amino codec so that this can later be | ||
| // used to properly serialize MsgSubmitProposal instances | ||
| RegisterLegacyAminoCodec(govcodec.Amino) | ||
| } |
There was a problem hiding this comment.
AminoCodec and init() function is deprecated
https://docs.cosmos.network/v0.50/build/migrations/upgrading#modules
Messages no longer need to implement the LegacyMsg interface and implementations of GetSignBytes can be deleted. Because of this change, global legacy Amino codec definitions and their registration in init() can safely be removed as well.
| // GetSignBytes implements sdk.Msg. | ||
| func (msg *MsgUnlinkApplication) GetSignBytes() []byte { | ||
| return sdk.MustSortJSON(AminoCdc.MustMarshalJSON(msg)) | ||
| } |
There was a problem hiding this comment.
It is deprecated, see: https://docs.cosmos.network/v0.50/build/migrations/upgrading#modules
Messages no longer need to implement the LegacyMsg interface and implementations of GetSignBytes can be deleted. Because of this change, global legacy Amino codec definitions and their registration in init() can safely be removed as well.
dadamu
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1246 +/- ##
===========================================
- Coverage 81.04% 17.63% -63.41%
===========================================
Files 218 372 +154
Lines 17880 105987 +88107
===========================================
+ Hits 14490 18695 +4205
- Misses 2778 85974 +83196
- Partials 612 1318 +706 ☔ View full report in Codecov by Sentry. |
This reverts commit f167dc1.
dadamu
force-pushed
the
paul/DCD-415/bump-cosmos-sdk-to-0.50.0
branch
from
76aed35
to
568b329
Compare
dadamu
changed the title
Description
Closes: #XXXX
This PR bumps cosmos-sdk to v0.50.0, ibc-go to v8 and wasmd to v0.50.0.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change