test: fix gomock controller finish #1231

dadamu · 2023-09-05T08:20:12Z

Description

This PR fixes the gomock controller finish by moving it to the TearDownTest phase, or it cannot find the missing calls of the function we setup on expected keepers.

It also fixes the tests having wrong setting on the expected keepers.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

…nsfer tests

…t test

dadamu · 2023-09-05T08:20:53Z

x/posts/keeper/genesis_test.go

@@ -291,34 +291,12 @@ func (suite *KeeperTestSuite) TestKeeper_ExportGenesis() {
 func (suite *KeeperTestSuite) TestKeeper_ImportGenesis() {
 	testCases := []struct {
 		name  string
-		setup func()


ImportGenesis does not require any expected keepers setting.

dadamu · 2023-09-05T08:21:52Z

x/subspaces/ante/tx_checker_test.go

-				suite.sk.EXPECT().
-					GetSubspace(gomock.Any(), uint64(1)).
-					Return(
-						types.Subspace{
-							AdditionalFeeTokens: sdk.NewCoins(sdk.NewCoin("minttoken", sdk.NewInt(1))),
-						},
-						true,
-					)


manage subspace transaction does not check the subspaces additional fee tokens.

dadamu · 2023-09-05T08:24:04Z

x/posts/keeper/msg_server_test.go

@@ -1491,14 +1491,6 @@ func (suite *KeeperTestSuite) TestMsgServer_RemovePostAttachment() {
 					"cosmos13t6y2nnugtshwuy0zkrq287a95lyy8vzleaxmd",
 					subspacestypes.NewPermission(types.PermissionModerateContent),
 				).Return(false)
-
-				suite.sk.EXPECT().HasPermission(


It does not check the EditOwnContent permission when post owner does not match the message sender.

dadamu · 2023-09-05T08:27:07Z

x/posts/keeper/msg_server_test.go

@@ -669,7 +669,7 @@ func (suite *KeeperTestSuite) TestMsgServer_EditPost() {
 					types.REPLY_SETTING_EVERYONE,
 					time.Date(2020, 1, 1, 12, 00, 00, 000, time.UTC),
 					nil,
-					"cosmos1r9jamre0x0qqy562rhhckt6sryztwhnvhafyz4",
+					"cosmos13t6y2nnugtshwuy0zkrq287a95lyy8vzleaxmd",


We should ensure the the owner of post stored is the same as the sender without EditOwnContent permission in this test

codecov · 2023-09-05T08:29:49Z

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

dadamu · 2023-09-05T08:30:17Z

x/posts/keeper/msg_server_test.go

@@ -1170,7 +1170,7 @@ func (suite *KeeperTestSuite) TestMsgServer_AddPostAttachment() {
 					gomock.Any(),
 					uint64(1),
 					uint32(0),
-					"cosmos1r9jamre0x0qqy562rhhckt6sryztwhnvhafyz4",
+					"cosmos13t6y2nnugtshwuy0zkrq287a95lyy8vzleaxmd",


We should ensure the the owner of post stored is the same as the sender without EditOwnContent permission in this test.

dadamu · 2023-09-05T08:30:27Z

x/posts/keeper/msg_server_test.go

@@ -1189,7 +1189,7 @@ func (suite *KeeperTestSuite) TestMsgServer_AddPostAttachment() {
 					types.REPLY_SETTING_EVERYONE,
 					time.Date(2020, 1, 1, 12, 00, 00, 000, time.UTC),
 					nil,
-					"cosmos1r9jamre0x0qqy562rhhckt6sryztwhnvhafyz4",
+					"cosmos13t6y2nnugtshwuy0zkrq287a95lyy8vzleaxmd",


dadamu · 2023-09-05T08:32:33Z

x/posts/keeper/msg_server_test.go

@@ -1845,6 +1837,24 @@ func (suite *KeeperTestSuite) TestMsgServer_AnswerPoll() {
 					subspacestypes.NewPermission(types.PermissionInteractWithContent),
 				).Return(false)
 			},
+			store: func(ctx sdk.Context) {
+				suite.k.SavePost(ctx, types.NewPost(


This is missing post should be stored before the test.

dadamu · 2023-09-05T08:32:56Z

x/posts/keeper/msg_server_test.go

@@ -3282,7 +3292,6 @@ func (suite *KeeperTestSuite) TestMsgServer_RequestPostOwnerTransfer() {
 func (suite *KeeperTestSuite) TestMsgServer_CancelPostOwnerTransfer() {
 	testCases := []struct {
 		name        string
-		setup       func()


CancelPostOwnerTransfer does not require expected keepers setting

dadamu · 2023-09-05T08:33:21Z

x/posts/keeper/msg_server_test.go

@@ -3649,7 +3639,6 @@ func (suite *KeeperTestSuite) TestMsgServer_AcceptPostOwnerTransfer() {
 func (suite *KeeperTestSuite) TestMsgServer_RefusePostOwnerTransfer() {
 	testCases := []struct {
 		name        string
-		setup       func()


As above, RefusePostOwnerTransfer does not require expected keepers setting

RiccardoM

Great job! 💯

## Description ~~Deps: #1231~~ This PR improves `x/profiles` by mutation tests to increase mutation score of `x/profiles` to 0.887324. ``` ################################################################################ ### WARNING! This test will take hours to complete! ################################################################################ running mutation tests for the following module(s): profiles writing mutation test result to mutation_test_result.txt The mutation score is 0.887324 (252 passed, 2 failed, 0 duplicated, 30 skipped, total is 284) ```  --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://docs.cosmos.network/v0.44/building-modules/intro.html) - [ ] included the necessary unit and integration [tests](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [x] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) --------- Co-authored-by: Riccardo <[email protected]>

dadamu added 7 commits September 5, 2023 15:38

test: move controller finish to tear down phase

6848af8

test: remove subspaces ante unused expected keepers setup

05ef832

test: remove posts genesis unused expected keepers setup

43c4457

test: fix add post attachment user without permissions test

996f680

test: fix cancel post owner transfer user without permissions test

90f5885

test: remove unused expected keepers for cancel/refuse post owner tra…

e8f2054

…nsfer tests

test: fix remove post attachment non moderator delete otehr attachmen…

d706806

…t test

dadamu requested a review from a team as a code owner September 5, 2023 08:20

github-actions bot added x/profiles Module that allows to create and manage decentralized social profiles x/subspaces Issue on the x/subspaces module x/relationships labels Sep 5, 2023

dadamu commented Sep 5, 2023

View reviewed changes

dadamu mentioned this pull request Sep 5, 2023

chore: improve x/profiles by mutation test #1227

Merged

19 tasks

RiccardoM approved these changes Sep 5, 2023

View reviewed changes

RiccardoM merged commit da5f561 into master Sep 5, 2023
33 checks passed

RiccardoM deleted the paul/fix-gomock-finish branch September 5, 2023 16:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: fix gomock controller finish #1231

test: fix gomock controller finish #1231

dadamu commented Sep 5, 2023

dadamu Sep 5, 2023

dadamu Sep 5, 2023

dadamu Sep 5, 2023

dadamu Sep 5, 2023 •

edited

Loading

codecov bot commented Sep 5, 2023

dadamu Sep 5, 2023

dadamu Sep 5, 2023

dadamu Sep 5, 2023

dadamu Sep 5, 2023 •

edited

Loading

dadamu Sep 5, 2023

RiccardoM left a comment

test: fix gomock controller finish #1231

test: fix gomock controller finish #1231

Conversation

dadamu commented Sep 5, 2023

Description

Author Checklist

Reviewers Checklist

dadamu Sep 5, 2023

Choose a reason for hiding this comment

dadamu Sep 5, 2023

Choose a reason for hiding this comment

dadamu Sep 5, 2023

Choose a reason for hiding this comment

dadamu Sep 5, 2023 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Sep 5, 2023

Codecov Report

dadamu Sep 5, 2023

Choose a reason for hiding this comment

dadamu Sep 5, 2023

Choose a reason for hiding this comment

dadamu Sep 5, 2023

Choose a reason for hiding this comment

dadamu Sep 5, 2023 • edited Loading

Choose a reason for hiding this comment

dadamu Sep 5, 2023

Choose a reason for hiding this comment

RiccardoM left a comment

Choose a reason for hiding this comment

dadamu Sep 5, 2023 •

edited

Loading

dadamu Sep 5, 2023 •

edited

Loading