Add support for hex address in chain link #685
Labels
kind/new-feature
Propose the addition of a new feature that does not yet exist
x/profiles
Module that allows to create and manage decentralized social profiles
Comments
dadamu
added
kind/new-feature
|
I agree with this. We should extend the support to ETH as well. Maybe this is worth for an ADR? @RiccardoM |
|
Agree this is something we should be supporting
No ADR is required for such a small change. We can just implement it. |
|
I will work on it soon. 👍 |
19 tasks
mergify bot
pushed a commit
that referenced
this issue
Dec 20, 2021
## Description Closes: #685 This PR is the implementation of #685. It extends the support to the hex address like ETH. Note: Rename PR to add support for eth address since eth address is generated in the other way. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://docs.cosmos.network/v0.44/building-modules/intro.html) - [x] included the necessary unit and integration [tests](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Feature description
Currently, Desmos doesn't support linking the hex address to the profile. Therefore, the user can't connect their address of Etheruem or other chains, which apply hex address, to the profile.
We should provide the possibility to create the chain link with a hex address.
Implementation proposal
Implement the Hex address structure for
AddressDatainterface.The text was updated successfully, but these errors were encountered: