Skip to content

Commit

Permalink
ci: fix split test files ci (#1316)
Browse files Browse the repository at this point in the history
## Description

Closes: #XXXX

<!-- Add a description of the changes that this PR introduces and the
files that
are the most critical to review. -->

This PR fixes the CI of splitting test files, currently, it always fails
since it requires `go mod tidy` to update `go.mod` before `go list`.

https://github.com/desmos-labs/desmos/actions/runs/8479093667/job/23232524696?pr=1309#step:3:172


---

### Author Checklist

*All items are required. Please add a note to the item if the item is
not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type
prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json)
in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR
Targeting](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building
modules](https://docs.cosmos.network/v0.44/building-modules/intro.html)
- [ ] included the necessary unit and integration
[tests](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go
code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable
and please add
your handle next to the items reviewed if you only reviewed selected
items.*

I have...

- [ ] confirmed the correct [type
prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json)
in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **Chores**
- Enhanced the GitHub workflow by incorporating `go mod tidy` before
listing packages to ensure a tidy module list.
- Introduced a change in CI for fixing split-test-files CI, ensuring
backward compatibility.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
dadamu authored Apr 2, 2024
1 parent bce3217 commit 69f86ae
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
type: ci
module: none
pull_request: 1316
description: Fix split-test-files ci
backward_compatible: true
date: 2024-03-29T08:53:21.646923062Z
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
uses: actions/checkout@v4

- name: Create a file with all the pkgs 📜
run: go list ./... > pkgs.txt
run: go mod tidy && go list ./... > pkgs.txt

- name: Split pkgs into 4 files ✂️
run: split -d -n l/4 pkgs.txt pkgs.txt.part.
Expand Down

0 comments on commit 69f86ae

Please sign in to comment.