Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ADR): ADR-006 Advertise contract #110

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

dadamu
Copy link
Contributor

@dadamu dadamu commented Oct 20, 2022

Description

This PR contains the ADR describing the implementation specs for the Advertise contract.

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed contract logic
  • reviewed contract security
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@leobragaz
Copy link
Collaborator

I've one question and some suggestions for this contract. Is the post selection probabilistic and only influenced by the amount of token I spend to sponsor it? So could it be that, even if I spent less DSMs to sponsor it, the contract select one of the "less sponsored" post instead of the most sponsored?

By the way, for how it is described in the ADR, this contract should be named more like "Sponsorship Contract" rather than "Advertisement Contract". I've written an idea of an advertisement contract inside this document here. It's still a WIP but you can already leave a comment.

@dadamu
Copy link
Contributor Author

dadamu commented Oct 25, 2022

@bragaz Yes, exactly. The exposure rate is influenced by the tokens. The contract would most frequently select the most sponsored/boosted post. Even if the user spent less DSMs to boost it, the post would be picked up, just the probabilistic would be low.

Yeah, agree with you, the idea is similar with promote and boost on Facebook. It is a advertisement specified for the user post, maybe "Promotion Contract" or "Boost Contract" is more proper to this contract. The initial idea is a post as an advertisement, and everyone can boost every post to let post have chance to exposure to any others.

@RiccardoM
Copy link
Contributor

@dadamu Can we please set this as "On Draft" so that it doesn't get merged by mistake? I would like to take a look at this as well, but unfortunately have to deal with other things in these days

@dadamu dadamu marked this pull request as draft October 25, 2022 14:10
@dadamu
Copy link
Contributor Author

dadamu commented Oct 25, 2022

@RiccardoM Okay, turned.

@dadamu dadamu requested a review from leobragaz October 28, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants