Bump Electron to v30.0.8 and node to v20.11.1 #18697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niik
approved these changes
May 29, 2024
|
We discussed in Slack that there is no reason to wait to merge this 🎉 The main drawback is that prod builds for Windows for arm64 will be broken for a while, since that node step was removed from our CI workflow. But that architecture is not supported nor advertised anyway, only betas are listed in our README file. |
|
how are you pls
Le mer. 29 mai 2024 à 10:12, Sergio Padrino ***@***.***> a
écrit :
… Merged #18697 <#18697> into
development.
—
Reply to this email directly, view it on GitHub
<#18697 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BIZG2RG3WLA3B4ZVRL3DE3TZEWLWHAVCNFSM6AAAAABINDQFSKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSHE3DQNJWGE3DINY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump Electron to v30.0.8 and node to v20.11.1. For the first time since we added support for arm64, we don't need a custom build of node for Windows arm64 🎉
Tested (
3.3.19-test1) on macOS and Windows, and no issues found so far 🎊Release notes
Notes: [Improved] Upgrade to Electron v30.0.8