Reopen default device if default is changed #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't the version with support for this API supposed to do this transparently? |
|
You mean it would work automatically after updating the library? I'm not sure but feel free to check |
|
Yeah. If you want the fix to land sooner, you can do an implementation without using unreleased openal APIs, e.g. look how it's implemented in tdesktop since long time ago: https://github.com/telegramdesktop/tdesktop/blob/dev/Telegram/SourceFiles/platform/win/audio_win.cpp |
|
Ok, unfortunately, for me, the issue is not high priority for now. Bit I might look into it. |
|
This will work differently soon, with native implementations for Windows / macOS. A fallback implementation on Linux using OpenAL APIs would be nice, I guess. I'll share some details soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After default device is changed in the system, the app will use new default.
Not sure which openal-soft version is good enough for this to work, seems to work well with current master.
Hopefully next release of openal will be sufficient.