-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple new settings, app components import, multiple format exports, static folder, ... #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdoflorenzano
changed the title
App component exports
Multiple new settings, app components import, multiple format exports, static folder, ...
May 4, 2022
fdoflorenzano
added
mechanic
About general mechanic functionalities
enhancement
New feature or request
labels
May 4, 2022
bravomartin
approved these changes
May 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful! Just some minor comments, mostly formal. Take any that make sense to you.
Approved! 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bunch of options that enable more personalization apart from custom imports:
Added
SideBar
React component that replaces sidebar in Mechanic UI. It's expected to be name-exported in in newapp/
folder in mechanic project.ExtraUi
, expected to be a React component that's added to the bottom section of sidebar, on top of default toggles and buttons.engine-react
andengine-svg
.hideFeedback
design function setting. When true, Mechanic's feedback button is hidden. Defaults to false.hideNavigation
design function setting. When true, the navigation input that let's users select a design function is hidden. Defaults to false.hidePresets
design function setting. When true, preset selection input is hidden. Defaults to false.hideScaleToFit
design function setting. When true, Scale to Fit toggle is hidden. Defaults to false.scaleToFit
design function setting. When false, Scale to Fit will be off initially. Defaults to true.hideAutoRefresh
design function setting. When true, Auto Refresh toggle is hidden. Defaults to false.autoRefresh
design function setting. When false, Auto Refresh will be off initially. Defaults to true.hideGenerate
design function setting. When true, Generate button is hidden. Defaults to false.showMultipleExports
design function setting. When false, single export button is shown. When true, two separate export buttons are shown: one for PNG export and another for SVG export. Defaults to false.ignoreStyles
design function setting. When true, CSS in iframe is injected into design function's SVG output. Defaults to false.static/
folder for all design functions. Allows to serve custom favicon._isPreview
value is passed to design function handler ininputs
argument. Allows design function to adjust if the render is a preview or an export.