feat(api): add Token.perm_manage_tokens and surrounding functionality #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterthomassen
force-pushed
the
20201106_token_perm_manage_tokens
branch
2 times, most recently
from
12eb65f to
40a0dfa
Compare
peterthomassen
force-pushed
the
20201106_token_perm_manage_tokens
branch
from
40a0dfa to
b4e0825
Compare
|
Docs update and GUI adjustments are done. Ready for review! |
peterthomassen
force-pushed
the
20201106_token_perm_manage_tokens
branch
7 times, most recently
from
01ef059 to
dfa9918
Compare
nils-wisiol
approved these changes
Nov 10, 2020
docs/auth/tokens.rst
Outdated
|
|
||
| ``token`` | ||
| :Access mode: read-once | ||
| :Type: string (28 characters) |
There was a problem hiding this comment.
Let's be not too specific with details here - this value could change in the future
|
|
||
| <script> | ||
| export default { | ||
| name: 'Checkbox', |
nils-wisiol
approved these changes
Nov 10, 2020
The migration sets `perm_manage_tokens = True` for all existing tokens, and then sets the default to `False`. Related: #347
peterthomassen
force-pushed
the
20201106_token_perm_manage_tokens
branch
from
010a29d to
f88acff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The migration sets
perm_manage_tokens = Truefor all existing tokens,and then sets the default to
False.Related: #347
Todos:
It may also be worthwhile to discuss why I called the field
perm_manage_tokens(I figured it would play along best with the other things we're going to add, but that we should talk about).