fix(api): regression: set customary content type for dyn responses

desec-io · Mar 2, 2021 · 899d9fb · 899d9fb
1 parent a2d49d6
commit 899d9fb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/api/desecapi/tests/test_dyndns12update.py b/api/desecapi/tests/test_dyndns12update.py
@@ -30,6 +30,7 @@ def test_identification_by_query_params(self):
         response = self.assertDynDNS12Update(username=self.my_domain.name, password=self.token.plain)
         self.assertStatus(response, status.HTTP_200_OK)
         self.assertEqual(response.data, 'good')
+        self.assertEqual(response.content_type, 'text/plain')
         self.assertIP(ipv4='127.0.0.1')
 
     def test_identification_by_query_params_with_subdomain(self):

diff --git a/api/desecapi/views.py b/api/desecapi/views.py
@@ -381,7 +381,7 @@ def get(self, request, *_):
         with PDNSChangeTracker():
             serializer.save()
 
-        return Response('good')
+        return Response('good', content_type='text/plain')
 
 
 class DonationList(generics.CreateAPIView):