Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve JSMPEG loading experience #261

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Improve JSMPEG loading experience #261

merged 1 commit into from
Jan 18, 2022

Conversation

dermotduffy
Copy link
Owner

  • Wait until the first frame is actually decoded before removing the progress spinner to avoid the 'white square' loading experience.
  • Change adaptive height handler to wait for the next browser repaint before measuring slide heights.
  • Closes Improve the JSMPEG live stream loading experience #243

@github-actions
Copy link

🎉 HACS repository validator action summary 🎉
✅ The repository is not archived
✅ hacs.json has the 'name' key set
✅ The repository has a description
✅ The repository has topics
✅ The repository has issues enabled
✅ This day ends with an 'y' (Tuesday)
✅ README.md exists
✅ Information file has images
⚪ Ignored check: hacs

@dermotduffy dermotduffy merged commit 585a8eb into main Jan 18, 2022
@NickM-27
Copy link
Contributor

Man this is smooth, a nice transition while loading

@dermotduffy dermotduffy deleted the jsmpeg-loading-improvements branch March 13, 2022 23:25
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the JSMPEG live stream loading experience
2 participants
@dermotduffy @NickM-27