Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android clip downloading #256

Merged
merged 1 commit into from
Jan 15, 2022
Merged

Fix Android clip downloading #256

merged 1 commit into from
Jan 15, 2022

Conversation

NickM-27
Copy link
Contributor

So turns out the iOS userAgent has a space but the Android userAgent doesn't. I tested this and the Android download button works as expected however the iOS button doesn't seem to work (nothing happens). I am wondering if the blank page doesn't work the same for iOS?

Fix for #241

@dermotduffy
Copy link
Owner

Thanks @NickM-27 . I have no way to test on iOS sadly. I think you're saying this 'add a space' fix words for Android, but iOS still doesn't work even with this PR? Don't suppose iOS works the fancier way? (i.e. the codepath without the _blank)?

@NickM-27
Copy link
Contributor Author

NickM-27 commented Jan 14, 2022

Thanks @NickM-27 . I have no way to test on iOS sadly. I think you're saying this 'add a space' fix words for Android, but iOS still doesn't work even with this PR? Don't suppose iOS works the fancier way? (i.e. the codepath without the _blank)?

Right, for some reason the user agent format differs between platforms. I just tested this and unfortunately it appears as though the fancy code block also doesn't work for iOS. I wonder if there are any other cards that offer similar functionality that might offer some insights.

Interesting, the surveillance-card has this for their download functionality: "Note: This functionality is not available in native app versions (iOS & Android) and depends on the browser/device's ability to download image files."

@NickM-27
Copy link
Contributor Author

In any case, this fixes #241 so should be good either way.

@dermotduffy dermotduffy merged commit 3b31699 into dermotduffy:main Jan 15, 2022
@dermotduffy dermotduffy added the bug Something isn't working label Feb 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants