Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fetching thumbnails separately #779

Merged
merged 3 commits into from
Aug 1, 2022

Conversation

dermotduffy
Copy link
Owner

  • An upcoming integration change will require uses of the BrowseMedia API to fetch thumbnails separately rather than using embedded base64 encoded thumbnails. This will result in a slightly worse card experience (thumbnails may take a very short time to load vs the appearance of being instantaneous) but allows encoded thumbnails to be removed from the database on the Frigate side.

Related PR: blakeblackshear/frigate-hass-integration#322

@dermotduffy dermotduffy changed the title Add support for fetching thumnails separately Add support for fetching thumbnails separately Jul 31, 2022
@dermotduffy dermotduffy mentioned this pull request Jul 31, 2022
@uvjustin
Copy link
Contributor

This seems like a good solution as it avoids some of the pitfalls you mentioned with the other approach. One thing to think about is the interaction with the service worker/cache. I ended up putting "static" in the new ThumbnailsProxyView endpoint name which means the assets should get cached by the service worker. I'm not sure, but that might also make the auth unnecessary after the first load.

@dermotduffy
Copy link
Owner Author

OK -- lets go with this one for now then so we can unblock your integration PR.

I'm not sure, but that might also make the auth unnecessary after the first load.

Yeah, but I'm not sure how to take advantage of that possibility easily without implementing an internal "has-loaded" cache and hoping the browser does the right thing...

@dermotduffy dermotduffy merged commit be72178 into release-4.0.0 Aug 1, 2022
@dermotduffy dermotduffy deleted the thumbnails-over-http branch August 1, 2022 02:17
uvjustin added a commit to uvjustin/frigate-hass-card that referenced this pull request Aug 2, 2022
…s-over-http"

This reverts commit be72178, reversing
changes made to c3500ce.
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants