[3.x] Laravel Framework 11.x and Laravel Dusk 8.x support #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match dependency versions of laravel/dusk 8.x for Laravel 10 & 11.
Laravel Dusk 8.x supports both. Feel free to submit a PR to this repo for Pest support.
* Add 'composer lint' command. * Update GitHub Actions CI command to latest v3 args. Changing CLI args in a minor version is a choice.
* @after annotation is replaced by the After attribute * Migrate phpunit.xml configuration to the current schema
laravel/dusk#1098 Laravel Dusk 8.x now defines these methods in class Laravel\Dusk\TestCase so the stub classes that extend TestCase don't need to redefine hasHeadlessDisabled() and shouldStartMaximized().
laravel/framework#50617 No need to instantiate all 3 of these commands when running another command.
Laravel 11+ apps may be missing file tests/CreatesApplication.php because its code has been moved into the framework as method Illuminate\Foundation\Testing\TestCase::createApplication(). Installing a new Dusk test case class stub will remove the unneeded CreatesApplication reference.
derekmd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34
@afterand@beforeClasswith PHPUnit v10+ attributes#[After]and#[BeforeClass].Derekmd\Dusk\Concerns\TogglesHeadlessMode::hasHeadlessDisabled()andshouldStartMaximized()now redundant in Laravel Dusk v8.TestCaseclass: MovehasHeadlessDisabled()andshouldStartMaximized()toLaravel\Dusk\TestCaselaravel/dusk#1098Derekmd\Dusk\Console\*Commandclasses now have lazy-definitions so these testing classes don't need to be instantiated when other Laravel commands are run in the local environment.php artisan dusk:install-firefoxhandles apps missing trait tests/CreatesApplication.php. Laravel 11 has pulled this trait's code into the framework.Note
Apps upgrading to "derekmd/laravel-dusk-firefox" v3.0 may need to run command
php artisan dusk:install-firefoxorphp artisan dusk:install-firefox --with-chrometo overwrite tests/DuskTestCase.php. If trait file tests/CreatesApplication.php still exists, this step isn't required.