-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Horde.Supervisor child_spec overridable #135
Make Horde.Supervisor child_spec overridable #135
Conversation
24c4ba9
to
dae9134
Compare
Hmm, running the tests locally it passes with:
Still, is failing in circleci with:
|
dae9134
to
2c14332
Compare
Oh, it was my mistake 😅 |
Also a good chance it was a wonky test! There are a couple of those here. |
test/supervisor_test.exs
Outdated
type: :supervisor | ||
} | ||
|
||
assert spec = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assertion isn't asserting anything I don't think. Should be ^spec
I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhh, it was testing... nothing 🙈 Already fixed!
0480f2d
to
320dde1
Compare
Looks great, thanks!! |
Fixes #107