Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Horde.Supervisor child_spec overridable #135

Merged

Conversation

ordepdev
Copy link
Contributor

@ordepdev ordepdev commented Jul 9, 2019

Fixes #107

@ordepdev ordepdev force-pushed the improve-module-based-supervisor branch 2 times, most recently from 24c4ba9 to dae9134 Compare July 9, 2019 16:01
@ordepdev
Copy link
Contributor Author

ordepdev commented Jul 9, 2019

Hmm, running the tests locally it passes with:

Finished in 37.9 seconds
3 properties, 70 tests, 0 failures, 1 skipped

Still, is failing in circleci with:

1) test .set_members/2 can join and unjoin registry with set_members (ClusterTest)
     test/cluster_test.exs:164
     match (=) failed
     code:  assert 1 = Enum.count(members)
     right: 2
     stacktrace:
       test/cluster_test.exs:190: (test)

Finished in 37.6 seconds
3 properties, 70 tests, 1 failure, 1 skipped

@ordepdev ordepdev force-pushed the improve-module-based-supervisor branch from dae9134 to 2c14332 Compare July 9, 2019 16:25
@ordepdev
Copy link
Contributor Author

ordepdev commented Jul 9, 2019

Oh, it was my mistake 😅

@derekkraan
Copy link
Owner

Also a good chance it was a wonky test! There are a couple of those here.

type: :supervisor
}

assert spec =
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assertion isn't asserting anything I don't think. Should be ^spec I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh, it was testing... nothing 🙈 Already fixed!

@ordepdev ordepdev force-pushed the improve-module-based-supervisor branch from 0480f2d to 320dde1 Compare July 9, 2019 22:48
@derekkraan derekkraan merged commit 95eb325 into derekkraan:master Jul 10, 2019
@derekkraan
Copy link
Owner

Looks great, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve module based supervisor
2 participants