Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default columns dialog does not save changes #215

Closed
sean-e opened this issue Apr 25, 2020 · 6 comments
Closed

default columns dialog does not save changes #215

sean-e opened this issue Apr 25, 2020 · 6 comments

Comments

@sean-e
Copy link
Contributor

sean-e commented Apr 25, 2020

  • Tools | Options | Default Settings | Default Columns | Details
  • Uncheck an item
  • Change the order of the first two items
  • press ok
  • press ok
  • Tools | Options | Default Settings | Default Columns | Details

Item that was unchecked is no longer unchecked.
Default order is back.

1.4.0.1592

sean-e added a commit to sean-e/explorerplusplus that referenced this issue Apr 25, 2020
@jczanfona
Copy link
Contributor

Solved with v1.4.0.1594
Can you test it?

@sean-e
Copy link
Contributor Author

sean-e commented Apr 25, 2020

Solved with v1.4.0.1594
Can you test it?

What is the basis for your statement that it was solved?
What change fixed it (aside from my pull request)?

sean-e added a commit to sean-e/explorerplusplus that referenced this issue Apr 26, 2020
@jczanfona
Copy link
Contributor

In the tests I did, it seemed to me that the problem was solved.

@sean-e
Copy link
Contributor Author

sean-e commented Apr 26, 2020

Interesting. Perhaps my steps to repro are dependent on some other default state as I've only used Exp++ for less than a week. I did confirm the failure occurs when built from master, hence my pull request.

@jczanfona
Copy link
Contributor

Remember to press in the menu: View - Save Column Layout as Default" with only have one tab, and then try to open others.
Last version is v1.4.0.1606

If you think the problem is solved, you can close this ticket.

@sean-e
Copy link
Contributor Author

sean-e commented Apr 27, 2020

That is a workaround for the bug I have described and for which I offered a fix via the PR.

fengjixuchui added a commit to fengjixuchui/explorerplusplus that referenced this issue Oct 10, 2020
fix for derceg#215 -- save changes to default column settings
derceg pushed a commit that referenced this issue Oct 31, 2020
@derceg derceg closed this as completed Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants