Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep URL hash across page transition, and jump to named element if present #31

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Keep URL hash across page transition, and jump to named element if present #31

merged 1 commit into from
Feb 27, 2023

Conversation

ericyhwang
Copy link
Contributor

This fixes a two-pronged issue causing links within the the same Derby app to not respect the link's URL hash.

  • The hash now gets set in the new window URL during page transition, instead of getting dropped entirely.
  • After page transition, the page now scrolls to the first element with an id matching the fragment, mimicking default browser behavior.

@ericyhwang ericyhwang merged commit 17a1dc9 into master Feb 27, 2023
@ericyhwang ericyhwang deleted the preserve-hash branch February 27, 2023 23:57
@ericyhwang ericyhwang mentioned this pull request Feb 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigbeck craigbeck craigbeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericyhwang @craigbeck