Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deferred destroy #24

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Fix deferred destroy #24

merged 2 commits into from
Dec 15, 2022

Conversation

craigbeck
Copy link
Contributor

Deferring the destroy of an as property reference would cause the deletion of the property even if the property had been changed to use a new reference e.g. where conditional rendering would replace a property with another component.

This fix add guard checking the reference is unchanged before deleting

@craigbeck craigbeck requested a review from ericyhwang December 15, 2022 22:47
@craigbeck craigbeck merged commit ab58f30 into master Dec 15, 2022
@craigbeck craigbeck deleted the fix-deferred-destroy branch December 15, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericyhwang ericyhwang ericyhwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@craigbeck @ericyhwang