Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build snap #2621

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix build snap #2621

merged 1 commit into from
Mar 19, 2024

Conversation

metanovii
Copy link
Contributor

No description provided.

@metanovii metanovii mentioned this pull request Mar 15, 2024
@jrib
Copy link

jrib commented Mar 18, 2024

I was about to open a similar PR when I saw yours opened. So I'll comment here instead with some additional changes to consider:

  1. I added completion. I'm happy to do that separately, as it is just a nice-to-have.
  2. I also changed the instructions in the README.md to use --classic instead of --devmode. That makes it more consistent with how the helm and the kubectl snaps both install.

@derailed
Copy link
Owner

@jrib Thank you Jason! It's hard for me to tell from the original pr how this will fix the snap install?
it would be could for you guys to sync up on the deltas or submit an additional pr to address the remaining issues.

@metanovii
Copy link
Contributor Author

it would be could for you guys to sync up on the deltas or submit an additional pr to address the remaining issues.
I think PR @jrib very nice.

@metanovii
Copy link
Contributor Author

@jrib please open your pr. I will close mine

@jrib
Copy link

jrib commented Mar 19, 2024

@metanovii sounds good. I opened it at #2633 if you want to discuss there

@jrib jrib mentioned this pull request Mar 19, 2024
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metanovii Thank you for these updates Sergey!

@derailed derailed merged commit c31a48f into derailed:master Mar 19, 2024
3 checks passed
@derailed derailed mentioned this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants