Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow presentation elements in list #4414

Closed
wants to merge 3 commits into from

Conversation

larowlan
Copy link

@larowlan larowlan commented Apr 18, 2024

Drupal is using markup like this for pagination/pager - the ... element is presentational only.

<ul>
  <li><a href="page-1" class="is-active">Go to page 1</a></li>
  <li><a href="page-2">Go to page 2</a></li>
  <li><a href="page-3">Go to page 3</a></li>
  <li><a href="page-4">Go to page 4</a></li>
  <li role="presentation">...</li>
  <li><a href="page-2">Go to next page</a></li>
</ul>

@larowlan larowlan requested a review from a team as a code owner April 18, 2024 05:22
@CLAassistant
Copy link

CLAassistant commented Apr 18, 2024

CLA assistant check
All committers have signed the CLA.

@straker
Copy link
Contributor

straker commented Apr 18, 2024

Thanks for the PR. Unfortunately a list containing a role=presentation child causes problems for screen readers. The content of the role=presentation item is still visible and can be navigated to. If the content of the list item should be hidden you should use aria-hidden.

Because of that we cannot accept the PR, so going to close.

@straker straker closed this Apr 18, 2024
@larowlan
Copy link
Author

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants