Minor build chores for whitespace and lockfile #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align the file with the EditorConfig setting
This file is produced by NPM 5, but this repo didn't use the old shrinkwrap version so this should be excluded
|
I think we'll actually want to add the lockfile to the repo. We've been experimenting with it internally and should probably come to a decision on that soon. |
|
Did you want me to rebase off that commit? |
|
@nschonni We have a call internally set for Monday to discuss our future build / release processes. One of the questions on the agenda is what to do with lock files. |
WilcoFiers
added a commit
that referenced
this pull request
Jul 13, 2017
* fix implicit attribute us in duplicate-id * fix: Only access node id's through getAttribute * Minor build chores for whitespace and lockfile (#366) * chore: convert spaces to tabs in Gruntfile Align the file with the EditorConfig setting * chore: ignore package-lock.json This file is produced by NPM 5, but this repo didn't use the old shrinkwrap version so this should be excluded * fix: Set relatedNodes on color/link-in-block rules (#407) * chore: ignore growl in retire * Add instructions on debugging on CircleCI * chore: Fix spacing issues * fix implicit attribute us in duplicate-id * fix: Only access node id's through getAttribute * chore: Fix spacing issues * fix: JSHint issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this during while creating another PR