Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aria-prohibited-attr): update metadata message #3206

Merged
merged 5 commits into from
Oct 14, 2021
Merged

fix(aria-prohibited-attr): update metadata message #3206

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ff1ff5f
add custom messageKey for prohibited attrs
Zidious Oct 13, 2021
6cf97e9
add additional metadata failure
Zidious Oct 13, 2021
29773d2
update metadata message
Zidious Oct 13, 2021
c25d609
update metadata message
Zidious Oct 13, 2021
7d0a7dd
update metadata message
Zidious Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/checks/aria/aria-prohibited-attr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"impact": "serious",
"messages": {
"pass": "ARIA attribute is allowed",
"fail": "ARIA attribute cannot be used, add a role attribute or use a different element: ${data.values}",
"incomplete": "ARIA attribute is not well supported on the element and the text content will be used instead: ${data.values}"
"fail": "ARIA attribute: ${data.values} is not allowed. Use a different role attribute or element.",
"incomplete": "ARIA attribute: ${data.values} is not well supported. Use a different role attribute or element."
}
}
}