Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(required-attrs): deprecate options to pass more required attrs #2377

Merged
merged 4 commits into from
Jul 16, 2020
Merged

feat(required-attrs): deprecate options to pass more required attrs #2377

merged 4 commits into from
Jul 16, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Jul 14, 2020 •
edited by WilcoFiers
Loading

Slider, spinbutton, and scrollbar all have implicit values so we didn't make them required anymore.

Part of issue #2108

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner July 14, 2020 20:38
@straker straker changed the title chore(required-attrs): make work with standards object feat(required-attrs): deprecate options to pass more required attrs Jul 15, 2020
@straker straker merged commit 797ee34 into develop Jul 16, 2020
@straker straker deleted the required-attrs branch July 16, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straker @WilcoFiers