Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix standard roles #2369

Merged
merged 1 commit into from
Jul 14, 2020
Merged

chore: fix standard roles #2369

merged 1 commit into from
Jul 14, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Jul 13, 2020

Noticed the none role wasn't in the standards object. I think what happened is I took the standards object as the base and compared it agains the lookup table instead of the other way around. So I did that and this is the new results (that are different than the ones we already approved in #2328 (comment))

allowed attrs is not present for role: doc-pullquote, ['aria-expanded']
allowed attrs is not present for role: rowgroup, ['aria-activedescendant', 'aria-expanded', 'aria-errormessage']

Also, fun fact: the dpub roles in the lookup table all use namefrom (no capital F) and so they would never return true when checking name from contents. But we wouldn't know because when we ask name from contents of a role, dpub roles are excluded from the list as we don't pass the dpub flag to getRole.

I find it odd that dpub roles are not counted as valid roles by default though...

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner July 13, 2020 18:06
@straker straker merged commit a5ed47a into develop Jul 14, 2020
@straker straker deleted the role-fixes branch July 14, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants