Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed the
none
role wasn't in the standards object. I think what happened is I took the standards object as the base and compared it agains the lookup table instead of the other way around. So I did that and this is the new results (that are different than the ones we already approved in #2328 (comment))Also, fun fact: the dpub roles in the lookup table all use
namefrom
(no capital F) and so they would never returntrue
when checking name from contents. But we wouldn't know because when we ask name from contents of a role, dpub roles are excluded from the list as we don't pass the dpub flag to getRole.I find it odd that dpub roles are not counted as valid roles by default though...
Reviewer checks
Required fields, to be filled out by PR reviewer(s)