Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aria-allowed-attr): Add aria-orientation to radiogroup role #2322

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

Andarist
Copy link
Contributor

@Andarist Andarist commented Jun 24, 2020

We can read here that:

remain undefined on roles where an expected default orientation is ambiguous (e.g., radiogroup).

which, according to my understanding, implies that aria-orientation is allowed on radiogroup role, which would also make sense as visually we can present it either horizontally or vertically.

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@Andarist Andarist requested a review from a team as a code owner June 24, 2020 15:13
Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, https://w3c.github.io/aria/#radiogroup shows aria-orientation is part of the inherited states and properties. Thanks for the pr.

@straker straker changed the title feat(checks): Add aria-orientation to radiogroup role fix(aria-allowed-attr): Add aria-orientation to radiogroup role Jun 24, 2020
@straker straker merged commit 5e1f922 into dequelabs:develop Jun 24, 2020
@Andarist Andarist deleted the radiogroup-orientation branch June 25, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants