feat(configure): add axeVersion property that checks compatibility of axe.version #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
changed the title
stephenmathieson
previously requested changes
Aug 29, 2019
|
I think we should also update the TypeScript definition. |
|
@WilcoFiers did you have any particular reason why you wanted the name of the prop to be |
WilcoFiers
reviewed
Aug 30, 2019
stephenmathieson
changed the title
straker
changed the title
WilcoFiers
previously requested changes
Sep 5, 2019
WilcoFiers
approved these changes
Sep 12, 2019
WilcoFiers
requested changes
Sep 12, 2019
| @@ -8,6 +8,32 @@ function configureChecksRulesAndBranding(spec) { | |||
| throw new Error('No audit configured'); | |||
| } | |||
|
|
|||
| if (spec.axeVersion) { | |||
There was a problem hiding this comment.
I should have caught this one earlier. But the ticket asks for adding both ver and axeVersion, where axeVersion is prioritised over ver if both are set. The intent is to have a fallback so that this can work for older custom rules as well.
| (major === axeMajor && | ||
| minor === axeMinor && | ||
| patch === axePatch && | ||
| ((canary && axeCanary) || (canary && !axeCanary))) |
There was a problem hiding this comment.
I'm thinking if the canary version is the same, it also shouldn't throw.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue: #1780
Reviewer checks
Required fields, to be filled out by PR reviewer(s)