Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a reference to the node a rule failed on #1321

Merged
merged 10 commits into from
Jan 21, 2019
Merged

feat: add a reference to the node a rule failed on #1321

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4612754
feat: add a reference to the `node` a rule failed on
stephenmathieson Jan 16, 2019
d6b46fc
Merge branch 'develop' into add-error-node-ref
stephenmathieson Jan 17, 2019
33f7b13
Merge branch 'develop' into add-error-node-ref
stephenmathieson Jan 17, 2019
61b97df
chore: serialize node
stephenmathieson Jan 18, 2019
3575878
Merge branch 'develop' into add-error-node-ref
stephenmathieson Jan 18, 2019
9786d5a
chore: use a DqElement
stephenmathieson Jan 18, 2019
1c13f90
Merge branch 'develop' into add-error-node-ref
jeeyyy Jan 21, 2019
2bd3116
fix: get node data on check error
jeeyyy Jan 21, 2019
5d687a2
chore: merge from develop
jeeyyy Jan 21, 2019
51981f1
fix: update eslint max-statements
jeeyyy Jan 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/core/base/audit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,10 @@ function getDefferedRule(rule, context, options) {
description: 'An error occured while running this rule',
message: err.message,
stack: err.stack,
error: err
error: err,
// Add a reference to the node the rule failed on for easier debugging.
// See https://github.com/dequelabs/axe-core/issues/1317.
node: err.node || null
});
// resolve
resolve(errResult);
Expand Down
2 changes: 2 additions & 0 deletions lib/core/base/check.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ Check.prototype.run = function(node, options, context, resolve, reject) {
context
);
} catch (e) {
// Save a reference to the node we errored on for futher debugging.
e.node = node;
reject(e);
return;
}
Expand Down