Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rule): frame-title applies to wcag242 #1312

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

mfairchild365
Copy link
Contributor

@mfairchild365 mfairchild365 commented Jan 15, 2019

I noticed that the fame-title rule was referencing wcag241 (bypass blocks). It should reference wcag242 instead.

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @WilcoFiers

@mfairchild365 mfairchild365 requested a review from a team as a code owner January 15, 2019 18:04
jeeyyy
jeeyyy previously requested changes Jan 15, 2019
Copy link
Contributor

@jeeyyy jeeyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfairchild365

Thanks for this.
Could you kindly run the step npm start or npm run build, this will regenerate the rule descriptions file - https://github.com/dequelabs/axe-core/blob/develop/doc/rule-descriptions.md with the right set of tags, which needs to be part of this PR.

@mfairchild365
Copy link
Contributor Author

@JKODU Thank you. I made the change.

@WilcoFiers
Copy link
Contributor

Thanks Michael.

@WilcoFiers WilcoFiers merged commit 9225ae0 into dequelabs:develop Jan 15, 2019
mfairchild365 added a commit to mfairchild365/axe-core that referenced this pull request Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants