ci: Speed up builds by caching node_modules #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch reduces the CircleCI build time by about ~2 minutes since do not have to `npm install` in most builds/scenarios.
We do not check `package-lock.json` in... whoops
jeeyyy
approved these changes
Jul 30, 2018
stephenmathieson
added a commit
that referenced
this pull request
Jul 31, 2018
* develop: feat(imports): add `doT` template engine (#1024) doc: ensure client is closed doc: fix comment doc: fix "parity" typo doc: ensure user starts chrome chore(package): auto-format *.ts files (#1029) build: replace babel-preset-es2015 with babel-preset-env (#1027) chore: remove `.jshintrc` files (#1028) chore: add `.npmrc` (#1026) chore: upgrade Prettier and run the formatter (#1030) doc(examples): add simple CDP example ci: Speed up builds by caching node_modules (#1025)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch reduces the CircleCI build time by about ~2 minutes since do not have to
npm installin most builds/scenarios.Reviewer checks
Required fields, to be filled out by PR reviewer(s)